New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance frame ID per frame build, rather than per new scene. #3370

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
4 participants
@gw3583
Copy link
Collaborator

gw3583 commented Nov 29, 2018

This fixes the way texture eviction works with picture caching
when scrolling or property animation is occurring.


This change is Reviewable

@gw3583

This comment has been minimized.

@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Nov 29, 2018

Try run looks good, I think. @bholley anything we need to do with eviction heuristics before landing this, or can they be tuned after?

@kvark

kvark approved these changes Nov 29, 2018

Copy link
Member

kvark left a comment

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@bholley

This comment has been minimized.

Copy link
Contributor

bholley commented Nov 29, 2018

We should land the updated heuristics at the same time. I just finished rebasing my instrumentation, but still need to measure/analyze. Have some meetings coming up but will try to get to that this afternoon.

@gw3583 gw3583 force-pushed the gw3583:frame-id branch from c302f3b to 3140ac9 Nov 30, 2018

Advance frame ID per frame build, rather than per new scene.
This fixes the way texture eviction works with picture caching
when scrolling or property animation is occurring.

@gw3583 gw3583 force-pushed the gw3583:frame-id branch from 3140ac9 to 3634b0c Nov 30, 2018

@bholley

This comment has been minimized.

Copy link
Contributor

bholley commented Nov 30, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Nov 30, 2018

📌 Commit 3634b0c has been approved by bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Nov 30, 2018

⌛️ Testing commit 3634b0c with merge d960500...

bors-servo added a commit that referenced this pull request Nov 30, 2018

Auto merge of #3370 - gw3583:frame-id, r=bholley
Advance frame ID per frame build, rather than per new scene.

This fixes the way texture eviction works with picture caching
when scrolling or property animation is occurring.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3370)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Nov 30, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: bholley
Pushing d960500 to master...

@bors-servo bors-servo merged commit 3634b0c into servo:master Nov 30, 2018

3 of 4 checks passed

code-review/reviewable 1 file left
Details
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 1, 2018

Bug 1511242 - Update webrender to commit d960500dfd4b55c21ae7ce6f0257…
…4f672cd015e0 (WR PR #3370). r=kats

servo/webrender#3370

Differential Revision: https://phabricator.services.mozilla.com/D13553

--HG--
extra : moz-landing-system : lando

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Dec 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment