New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store clip node templates in local space. #3383

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@gw3583
Copy link
Collaborator

gw3583 commented Dec 4, 2018

This change makes clip item keys independent of the local space
origin of the node. This ensures that even when Gecko sends a
new display list with clip nodes that have different scroll offsets
the interning logic results in the same uid for the clip node,
avoiding unnecessary invalidations of cached picture tiles.


This change is Reviewable

Store clip node templates in local space.
This change makes clip item keys independent of the local space
origin of the node. This ensures that even when Gecko sends a
new display list with clip nodes that have different scroll offsets
the interning logic results in the same uid for the clip node,
avoiding unnecessary invalidations of cached picture tiles.
@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Dec 4, 2018

This is a hack minimal effort to get clip nodes interning correctly even when Gecko supplies a new display list with clip nodes that have scroll offsets applied.

If you have ideas on tidier ways to implement this, let me know.

r? @kvark

@gw3583 gw3583 requested a review from kvark Dec 4, 2018

@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Dec 4, 2018

@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Dec 4, 2018

Try run looks good.

@kvark

This comment has been minimized.

Copy link
Member

kvark commented Dec 5, 2018

Closing in favor of #3384

@kvark kvark closed this Dec 5, 2018

@gw3583 gw3583 deleted the gw3583:seg-fix-13 branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment