New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch segments to be defined relative to the local primitive position. #3384

Merged
merged 2 commits into from Dec 5, 2018

Conversation

Projects
None yet
3 participants
@gw3583
Copy link
Collaborator

gw3583 commented Dec 4, 2018

This change is Reviewable

gw3583 added some commits Dec 4, 2018

Store clip node templates in local space.
This change makes clip item keys independent of the local space
origin of the node. This ensures that even when Gecko sends a
new display list with clip nodes that have different scroll offsets
the interning logic results in the same uid for the clip node,
avoiding unnecessary invalidations of cached picture tiles.
@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Dec 4, 2018

r? @kvark

This is a very small patch - it just looks big because it includes #3383.

@gw3583

This comment has been minimized.

@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Dec 5, 2018

Try run looks good.

@kvark

kvark approved these changes Dec 5, 2018

Copy link
Member

kvark left a comment

:lgtm:

I had some concerns, but they got resolved upon reading to the end of the PR :)

Reviewed 18 of 18 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gw3583)


webrender/res/cs_clip_rectangle.glsl, line 68 at r1 (raw file):

    RectWithSize local_rect = clip.rect.rect;
    local_rect.p0 = cmi.local_pos;

I read it as local_rect.p0 is guaranteed to be zero here


webrender/src/box_shadow.rs, line 202 at r1 (raw file):

                shadow_rect,
                shadow_radius,
                dest_rect.translate(&LayoutVector2D::new(-prim_info.rect.origin.x, -prim_info.rect.origin.y)),

nit: -prim_info.rect.origin.to_vector()?

@kvark

This comment has been minimized.

Copy link
Member

kvark commented Dec 5, 2018

@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 5, 2018

📌 Commit 46700de has been approved by kvark

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 5, 2018

⌛️ Testing commit 46700de with merge 7c4162c...

bors-servo added a commit that referenced this pull request Dec 5, 2018

Auto merge of #3384 - gw3583:local-seg, r=kvark
Switch segments to be defined relative to the local primitive position.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3384)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 5, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 7c4162c to master...

@bors-servo bors-servo merged commit 46700de into servo:master Dec 5, 2018

3 of 4 checks passed

code-review/reviewable 2 discussions left (gw3583)
Details
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 5, 2018

Bug 1512157 - Update webrender to commit 7c4162c581978d1a72ed2271a943…
…82290855e227 (WR PR #3384). r=kats

servo/webrender#3384

Differential Revision: https://phabricator.services.mozilla.com/D13799

--HG--
extra : moz-landing-system : lando

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment