New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory profile counters for interners. #3391

Merged
merged 1 commit into from Dec 7, 2018

Conversation

Projects
None yet
3 participants
@gw3583
Copy link
Collaborator

gw3583 commented Dec 6, 2018

This doesn't include indirect memory referenced by the interned
primitives (e.g. glyph arrays), but it's a start point, and gives
a good sense of how often new primitives are being interned.


This change is Reviewable

Add memory profile counters for interners.
This doesn't include indirect memory referenced by the interned
primitives (e.g. glyph arrays), but it's a start point, and gives
a good sense of how often new primitives are being interned.
@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Dec 6, 2018

r? @kvark or anyone

@kvark

kvark approved these changes Dec 7, 2018

@kvark

This comment has been minimized.

Copy link
Member

kvark commented Dec 7, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 7, 2018

📌 Commit 91ddaf6 has been approved by kvark

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 7, 2018

⌛️ Testing commit 91ddaf6 with merge baf98a2...

bors-servo added a commit that referenced this pull request Dec 7, 2018

Auto merge of #3391 - gw3583:intern-profile, r=kvark
Add memory profile counters for interners.

This doesn't include indirect memory referenced by the interned
primitives (e.g. glyph arrays), but it's a start point, and gives
a good sense of how often new primitives are being interned.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3391)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 7, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing baf98a2 to master...

@bors-servo bors-servo merged commit 91ddaf6 into servo:master Dec 7, 2018

3 of 4 checks passed

code-review/reviewable 3 files left
Details
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 7, 2018

Bug 1512628 - Update webrender to commit baf98a257705ccb2b0b58c9421b8…
…0faccf09001c (WR PR #3391). r=kats

servo/webrender#3391

Differential Revision: https://phabricator.services.mozilla.com/D13977

--HG--
extra : moz-landing-system : lando

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Dec 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment