New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store glyphs in a normalized local space. #3395

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
3 participants
@gw3583
Copy link
Collaborator

gw3583 commented Dec 9, 2018

This prevents text runs being interned more often than they
should be when scrolling in Gecko.


This change is Reviewable

Store glyphs in a normalized local space.
This prevents text runs being interned more often than they
should be when scrolling in Gecko.
@gw3583

This comment has been minimized.

@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Dec 10, 2018

Try run looks good.

@kvark kvark self-requested a review Dec 11, 2018

@kvark

kvark approved these changes Dec 12, 2018

@kvark

This comment has been minimized.

Copy link
Member

kvark commented Dec 12, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

📌 Commit f95c16a has been approved by kvark

bors-servo added a commit that referenced this pull request Dec 12, 2018

Auto merge of #3395 - gw3583:unit-text, r=kvark
Store glyphs in a normalized local space.

This prevents text runs being interned more often than they
should be when scrolling in Gecko.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3395)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

⌛️ Testing commit f95c16a with merge a6700da...

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing a6700da to master...

@bors-servo bors-servo merged commit f95c16a into servo:master Dec 12, 2018

2 of 3 checks passed

Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 12, 2018

Bug 1513126 - Update webrender to commit a6700dac955d9fe8fc6e68668969…
…b02c2d803dbf (WR PR #3395). r=kats

servo/webrender#3395

Differential Revision: https://phabricator.services.mozilla.com/D14248

--HG--
extra : moz-landing-system : lando

qdot pushed a commit to qdot/gecko-hg that referenced this pull request Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment