New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark picture cached tiles as opaque. #3396

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
4 participants
@gw3583
Copy link
Collaborator

gw3583 commented Dec 9, 2018

We know that all picture cache tiles are opaque, for now, due to
the background color of the content frame being opaque. This
gives a good performance win by putting these tiles into the
opaque pass.

If we ever decide we want to support non-opaque tiles, we can
add the logic to handle this correctly at that time, making use
of the segment batching logic to draw the cached tiles.


This change is Reviewable

Mark picture cached tiles as opaque.
We know that all picture cache tiles are opaque, for now, due to
the background color of the content frame being opaque. This
gives a good performance win by putting these tiles into the
opaque pass.

If we ever decide we want to support non-opaque tiles, we can
add the logic to handle this correctly at that time, making use
of the segment batching logic to draw the cached tiles.
@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Dec 9, 2018

r? @kvark or anyone

@nical

This comment has been minimized.

Copy link
Collaborator

nical commented Dec 12, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

📌 Commit bee2deb has been approved by nical

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

⌛️ Testing commit bee2deb with merge 7006af2...

bors-servo added a commit that referenced this pull request Dec 12, 2018

Auto merge of #3396 - gw3583:opaque-tiles, r=nical
Mark picture cached tiles as opaque.

We know that all picture cache tiles are opaque, for now, due to
the background color of the content frame being opaque. This
gives a good performance win by putting these tiles into the
opaque pass.

If we ever decide we want to support non-opaque tiles, we can
add the logic to handle this correctly at that time, making use
of the segment batching logic to draw the cached tiles.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3396)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

💔 Test failed - status-taskcluster

@staktrace

This comment has been minimized.

Copy link
Contributor

staktrace commented Dec 12, 2018

sccache failure, mozilla/sccache#344

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

⌛️ Testing commit bee2deb with merge 12e108d...

bors-servo added a commit that referenced this pull request Dec 12, 2018

Auto merge of #3396 - gw3583:opaque-tiles, r=nical
Mark picture cached tiles as opaque.

We know that all picture cache tiles are opaque, for now, due to
the background color of the content frame being opaque. This
gives a good performance win by putting these tiles into the
opaque pass.

If we ever decide we want to support non-opaque tiles, we can
add the logic to handle this correctly at that time, making use
of the segment batching logic to draw the cached tiles.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3396)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

💔 Test failed - status-taskcluster

@staktrace

This comment has been minimized.

Copy link
Contributor

staktrace commented Dec 12, 2018

@bors-servo retry

If this keeps happening I might just disable sccache because it's hurting more than helping right now.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

⌛️ Testing commit bee2deb with merge 597a1ef...

bors-servo added a commit that referenced this pull request Dec 12, 2018

Auto merge of #3396 - gw3583:opaque-tiles, r=nical
Mark picture cached tiles as opaque.

We know that all picture cache tiles are opaque, for now, due to
the background color of the content frame being opaque. This
gives a good performance win by putting these tiles into the
opaque pass.

If we ever decide we want to support non-opaque tiles, we can
add the logic to handle this correctly at that time, making use
of the segment batching logic to draw the cached tiles.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3396)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

💔 Test failed - status-taskcluster

@staktrace

This comment has been minimized.

Copy link
Contributor

staktrace commented Dec 12, 2018

@bors-servo retry

Landed sccache disabling in #3402 so it should work better now.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

⌛️ Testing commit bee2deb with merge bf98e0c...

bors-servo added a commit that referenced this pull request Dec 12, 2018

Auto merge of #3396 - gw3583:opaque-tiles, r=nical
Mark picture cached tiles as opaque.

We know that all picture cache tiles are opaque, for now, due to
the background color of the content frame being opaque. This
gives a good performance win by putting these tiles into the
opaque pass.

If we ever decide we want to support non-opaque tiles, we can
add the logic to handle this correctly at that time, making use
of the segment batching logic to draw the cached tiles.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3396)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing bf98e0c to master...

@bors-servo bors-servo merged commit bee2deb into servo:master Dec 12, 2018

2 of 3 checks passed

Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 13, 2018

Bug 1513683 - Update webrender to commit bf98e0cbde3ac885f55ff536ace1…
…39e1dc4f080f (WR PR #3396). r=kats

servo/webrender#3396

Differential Revision: https://phabricator.services.mozilla.com/D14311

--HG--
extra : moz-landing-system : lando

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment