Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMark picture cached tiles as opaque. #3396
Merged
Conversation
We know that all picture cache tiles are opaque, for now, due to the background color of the content frame being opaque. This gives a good performance win by putting these tiles into the opaque pass. If we ever decide we want to support non-opaque tiles, we can add the logic to handle this correctly at that time, making use of the segment batching logic to draw the cached tiles.
|
r? @kvark or anyone |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 12, 2018
Mark picture cached tiles as opaque. We know that all picture cache tiles are opaque, for now, due to the background color of the content frame being opaque. This gives a good performance win by putting these tiles into the opaque pass. If we ever decide we want to support non-opaque tiles, we can add the logic to handle this correctly at that time, making use of the segment batching logic to draw the cached tiles. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3396) <!-- Reviewable:end -->
|
|
|
sccache failure, mozilla/sccache#344 @bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Dec 12, 2018
Mark picture cached tiles as opaque. We know that all picture cache tiles are opaque, for now, due to the background color of the content frame being opaque. This gives a good performance win by putting these tiles into the opaque pass. If we ever decide we want to support non-opaque tiles, we can add the logic to handle this correctly at that time, making use of the segment batching logic to draw the cached tiles. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3396) <!-- Reviewable:end -->
|
|
|
@bors-servo retry If this keeps happening I might just disable sccache because it's hurting more than helping right now. |
bors-servo
added a commit
that referenced
this pull request
Dec 12, 2018
Mark picture cached tiles as opaque. We know that all picture cache tiles are opaque, for now, due to the background color of the content frame being opaque. This gives a good performance win by putting these tiles into the opaque pass. If we ever decide we want to support non-opaque tiles, we can add the logic to handle this correctly at that time, making use of the segment batching logic to draw the cached tiles. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3396) <!-- Reviewable:end -->
|
|
|
@bors-servo retry Landed sccache disabling in #3402 so it should work better now. |
bors-servo
added a commit
that referenced
this pull request
Dec 12, 2018
Mark picture cached tiles as opaque. We know that all picture cache tiles are opaque, for now, due to the background color of the content frame being opaque. This gives a good performance win by putting these tiles into the opaque pass. If we ever decide we want to support non-opaque tiles, we can add the logic to handle this correctly at that time, making use of the segment batching logic to draw the cached tiles. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3396) <!-- Reviewable:end -->
|
|
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 13, 2018
…39e1dc4f080f (WR PR #3396). r=kats servo/webrender#3396 Differential Revision: https://phabricator.services.mozilla.com/D14311 --HG-- extra : moz-landing-system : lando
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Dec 13, 2018
…39e1dc4f080f (WR PR #3396). r=kats servo/webrender#3396 Differential Revision: https://phabricator.services.mozilla.com/D14311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gw3583 commentedDec 9, 2018
•
edited by larsbergstrom
We know that all picture cache tiles are opaque, for now, due to
the background color of the content frame being opaque. This
gives a good performance win by putting these tiles into the
opaque pass.
If we ever decide we want to support non-opaque tiles, we can
add the logic to handle this correctly at that time, making use
of the segment batching logic to draw the cached tiles.
This change is