New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of zero regions by texture allocator #3404

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
3 participants
@kvark
Copy link
Member

kvark commented Dec 12, 2018

@kvark kvark requested a review from gw3583 Dec 12, 2018

@kvark kvark changed the title Fix handling of zero regions by texture allocator [WIP] Fix handling of zero regions by texture allocator Dec 12, 2018

@gw3583

gw3583 approved these changes Dec 12, 2018

Copy link
Collaborator

gw3583 left a comment

Should we also add a debug log / warning that there was a zero sized task, so that we can detect those and catch them at a higher level? Maybe in the future we could then assert on the alloc size being valid?

@kvark kvark force-pushed the kvark:alloc-zero branch from 348d14c to 37f20f8 Dec 12, 2018

@kvark

This comment has been minimized.

Copy link
Member

kvark commented Dec 12, 2018

@gw3583 ideally, yes. I suggest we continue the investigation of the actual cause after we put this fire down ;) Speaking of which, this version is confirmed to fix the bug, it's ready for the review.

@kvark kvark changed the title [WIP] Fix handling of zero regions by texture allocator Fix handling of zero regions by texture allocator Dec 12, 2018

@kvark

This comment has been minimized.

@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Dec 12, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

📌 Commit 37f20f8 has been approved by gw3583

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

⌛️ Testing commit 37f20f8 with merge 4b32d1e...

bors-servo added a commit that referenced this pull request Dec 12, 2018

Auto merge of #3404 - kvark:alloc-zero, r=gw3583
Fix handling of zero regions by texture allocator

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1513017

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3404)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

💔 Test failed - status-appveyor

@kvark kvark force-pushed the kvark:alloc-zero branch from 37f20f8 to 55c483d Dec 12, 2018

@kvark

This comment has been minimized.

Copy link
Member

kvark commented Dec 12, 2018

One trivial fixup (derive PartialEq for a slice index)
@bors-servo r=gw3583

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

📌 Commit 55c483d has been approved by gw3583

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

⌛️ Testing commit 55c483d with merge 7f589fd...

bors-servo added a commit that referenced this pull request Dec 12, 2018

Auto merge of #3404 - kvark:alloc-zero, r=gw3583
Fix handling of zero regions by texture allocator

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1513017

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3404)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 12, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 7f589fd to master...

@bors-servo bors-servo merged commit 55c483d into servo:master Dec 12, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@kvark kvark deleted the kvark:alloc-zero branch Dec 13, 2018

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 13, 2018

Bug 1513747 - Update webrender to commit 7f589fd3a57fcd4888cb39fc5f54…
…da215aa99b19 (WR PR #3404). r=kats

servo/webrender#3404

Differential Revision: https://phabricator.services.mozilla.com/D14359

--HG--
extra : moz-landing-system : lando

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment