Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upClear clip_node_instances on new frame builds. #3417
Merged
Conversation
|
This fixes the issue for me locally but I don't know if it breaks correctness elsewhere |
|
Try push is green. r? @kvark |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 14, 2018
Clear clip_node_instances on new frame builds. The clip node instances are rebuilt for each frame built from a given scene, but are not cleared until a new scene is built. So if a given scene builds many frames, the clip node instances just accumulate and eat up memory. Fixes #3416. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3417) <!-- Reviewable:end -->
|
|
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 15, 2018
…ddc3c4e8f97d (WR PR #3417). r=kats servo/webrender#3417 Differential Revision: https://phabricator.services.mozilla.com/D14624 --HG-- extra : moz-landing-system : lando
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Dec 15, 2018
…ddc3c4e8f97d (WR PR #3417). r=kats servo/webrender#3417 Differential Revision: https://phabricator.services.mozilla.com/D14624
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…ddc3c4e8f97d (WR PR #3417). r=kats servo/webrender#3417 Differential Revision: https://phabricator.services.mozilla.com/D14624 UltraBlame original commit: 305e1b5c76177bcb031552fc3784204a3207a9b4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…ddc3c4e8f97d (WR PR #3417). r=kats servo/webrender#3417 Differential Revision: https://phabricator.services.mozilla.com/D14624 UltraBlame original commit: 305e1b5c76177bcb031552fc3784204a3207a9b4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…ddc3c4e8f97d (WR PR #3417). r=kats servo/webrender#3417 Differential Revision: https://phabricator.services.mozilla.com/D14624 UltraBlame original commit: 305e1b5c76177bcb031552fc3784204a3207a9b4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
staktrace commentedDec 14, 2018
•
edited by larsbergstrom
The clip node instances are rebuilt for each frame built from a given
scene, but are not cleared until a new scene is built. So if a given
scene builds many frames, the clip node instances just accumulate and
eat up memory.
Fixes #3416.
This change is