Separate interning borders

[djg]

In support of #3385, extract normal and image borders. This patch is based up PR #3393 and requires that to land first.

---

This change is 

[gw3583]

#3393 has landed now, so it should be possible to rebase this and remove those commits.

[gw3583]

Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @djg)

---

webrender/src/border.rs, line 16 at r1 (raw file):

use prim_store::{BorderSegmentInfo, BrushSegment, NinePatchDescriptor};
use prim_store::{EdgeAaSegmentMask, ScrollNodeAndClipChain};
use prim_store::borders::NormalBorder;

I wonder if we should call these something like NormalBorderDescriptor or something like that to avoid naming conflicts with the API structs? Not something we need to do now, but perhaps consider as a follow up?

[gw3583]

One question - can either ignore or do as a follow up, if that's easier.

Apart from that, looks good to me - do we want a try / talos run before merging? (I suspect this might have a decent perf win on dl_mutate, given the reduction in primitive key size).

@bors-servo delegate+

[bors-servo]

✌️ @djg can now approve this pull request

[djg]

I have try / talos scheduled. You beat me to it: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ab2321c567ca56aa43f1614d7dccf94a816d62e

[djg]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gw3583)

---

webrender/src/border.rs, line 16 at r1 (raw file):

Previously, gw3583 (Glenn Watson) wrote…

I wonder if we should call these something like NormalBorderDescriptor or something like that to avoid naming conflicts with the API structs? Not something we need to do now, but perhaps consider as a follow up?

NormalBorderPrim?

[djg]

@bors-servo r=gw

[bors-servo]

📌 Commit cb4c247 has been approved by gw

[bors-servo]

⌛ Testing commit cb4c247 with merge d554558...

[djg]

@bors-servo r=gw

[bors-servo]

📌 Commit ce020d4 has been approved by gw

[bors-servo]

⌛ Testing commit ce020d4 with merge 14df2e4...

[bors-servo]

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw
Pushing 14df2e4 to master...