New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant cluster range, as an optimization. #3433

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
3 participants
@gw3583
Copy link
Collaborator

gw3583 commented Dec 18, 2018

Initially I was planning to have primitives belong to multiple
clusters as part of the picture caching work, however this turned
out to not be required.

This patch removes support for that, which reduces the size of
PrimitiveInstance, and removes the prim cluster map from the
PrimitiveList.

Also reduce the size of the clip task index field as an additional
small struct size optimization.


This change is Reviewable

@gw3583

This comment has been minimized.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 18, 2018

☔️ The latest upstream changes (presumably #3429) made this pull request unmergeable. Please resolve the merge conflicts.

@kvark

kvark approved these changes Dec 18, 2018

Remove redundant cluster range, as an optimization.
Initially I was planning to have primitives belong to multiple
clusters as part of the picture caching work, however this turned
out to not be required.

This patch removes support for that, which reduces the size of
PrimitiveInstance, and removes the prim cluster map from the
PrimitiveList.

Also reduce the size of the clip task index field as an additional
small struct size optimization.

@gw3583 gw3583 force-pushed the gw3583:cluster-opt branch from 2dd1cb3 to 1b9b88d Dec 18, 2018

@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Dec 18, 2018

Rebased to fix the conflict around some use statements.

@bors-servo r=kvark

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 18, 2018

📌 Commit 1b9b88d has been approved by kvark

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 18, 2018

⌛️ Testing commit 1b9b88d with merge 237346c...

bors-servo added a commit that referenced this pull request Dec 18, 2018

Auto merge of #3433 - gw3583:cluster-opt, r=kvark
Remove redundant cluster range, as an optimization.

Initially I was planning to have primitives belong to multiple
clusters as part of the picture caching work, however this turned
out to not be required.

This patch removes support for that, which reduces the size of
PrimitiveInstance, and removes the prim cluster map from the
PrimitiveList.

Also reduce the size of the clip task index field as an additional
small struct size optimization.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3433)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 18, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 237346c to master...

@bors-servo bors-servo merged commit 1b9b88d into servo:master Dec 18, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 19, 2018

Bug 1515243 - Update webrender to commit 237346c5e38cf70749e86a7f402f…
…d9f92b4b5226 (WR PR #3433). r=kats

servo/webrender#3433

Differential Revision: https://phabricator.services.mozilla.com/D14938

--HG--
extra : moz-landing-system : lando

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment