Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove redundant cluster range, as an optimization. #3433
Merged
+20
−83
Conversation
|
|
Initially I was planning to have primitives belong to multiple clusters as part of the picture caching work, however this turned out to not be required. This patch removes support for that, which reduces the size of PrimitiveInstance, and removes the prim cluster map from the PrimitiveList. Also reduce the size of the clip task index field as an additional small struct size optimization.
|
Rebased to fix the conflict around some @bors-servo r=kvark |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 18, 2018
Remove redundant cluster range, as an optimization. Initially I was planning to have primitives belong to multiple clusters as part of the picture caching work, however this turned out to not be required. This patch removes support for that, which reduces the size of PrimitiveInstance, and removes the prim cluster map from the PrimitiveList. Also reduce the size of the clip task index field as an additional small struct size optimization. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3433) <!-- Reviewable:end -->
|
|
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 19, 2018
…d9f92b4b5226 (WR PR #3433). r=kats servo/webrender#3433 Differential Revision: https://phabricator.services.mozilla.com/D14938 --HG-- extra : moz-landing-system : lando
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Dec 19, 2018
…d9f92b4b5226 (WR PR #3433). r=kats servo/webrender#3433 Differential Revision: https://phabricator.services.mozilla.com/D14938
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…d9f92b4b5226 (WR PR #3433). r=kats servo/webrender#3433 Differential Revision: https://phabricator.services.mozilla.com/D14938 UltraBlame original commit: 5baefeddca0c454365b5761f87edf47b696f25b4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…d9f92b4b5226 (WR PR #3433). r=kats servo/webrender#3433 Differential Revision: https://phabricator.services.mozilla.com/D14938 UltraBlame original commit: 5baefeddca0c454365b5761f87edf47b696f25b4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…d9f92b4b5226 (WR PR #3433). r=kats servo/webrender#3433 Differential Revision: https://phabricator.services.mozilla.com/D14938 UltraBlame original commit: 5baefeddca0c454365b5761f87edf47b696f25b4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gw3583 commentedDec 18, 2018
•
edited by larsbergstrom
Initially I was planning to have primitives belong to multiple
clusters as part of the picture caching work, however this turned
out to not be required.
This patch removes support for that, which reduces the size of
PrimitiveInstance, and removes the prim cluster map from the
PrimitiveList.
Also reduce the size of the clip task index field as an additional
small struct size optimization.
This change is