New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't snap UV coordinates when they are going to be used with the Spl… #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gw3583
approved these changes
Dec 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small nits, otherwise looks good!
mattwoodrow
force-pushed
the
dont-snap
branch
2 times, most recently
from
December 18, 2018 22:01
1f79f60
to
d45e329
Compare
…itComposite shader (which doesn't support snapping)
mattwoodrow
force-pushed
the
dont-snap
branch
from
December 18, 2018 22:13
d45e329
to
bac0a04
Compare
@bors-servo delegate+ |
✌️ @mattwoodrow can now approve this pull request |
@bors-servo r+ |
📌 Commit bac0a04 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 18, 2018
Don't snap UV coordinates when they are going to be used with the Spl… …itComposite shader (which doesn't support snapping). This fixes gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1509428 Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=01069308445460e1dc77709d1ec86b6605a6af3e <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3435) <!-- Reviewable:end -->
☀️ Test successful - status-appveyor, status-taskcluster |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 19, 2018
…42f7845982d1 (WR PR #3435). r=kats servo/webrender#3435 Differential Revision: https://phabricator.services.mozilla.com/D14939 --HG-- extra : moz-landing-system : lando
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Dec 19, 2018
…42f7845982d1 (WR PR #3435). r=kats servo/webrender#3435 Differential Revision: https://phabricator.services.mozilla.com/D14939
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…42f7845982d1 (WR PR #3435). r=kats servo/webrender#3435 Differential Revision: https://phabricator.services.mozilla.com/D14939 UltraBlame original commit: 6cfb1fdf1ddc001f75b304c219ddb8b3c13dcab7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…42f7845982d1 (WR PR #3435). r=kats servo/webrender#3435 Differential Revision: https://phabricator.services.mozilla.com/D14939 UltraBlame original commit: 6cfb1fdf1ddc001f75b304c219ddb8b3c13dcab7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…42f7845982d1 (WR PR #3435). r=kats servo/webrender#3435 Differential Revision: https://phabricator.services.mozilla.com/D14939 UltraBlame original commit: 6cfb1fdf1ddc001f75b304c219ddb8b3c13dcab7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…itComposite shader (which doesn't support snapping).
This fixes gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1509428
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=01069308445460e1dc77709d1ec86b6605a6af3e
This change is