New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't snap UV coordinates when they are going to be used with the Spl… #3435

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@mattwoodrow
Copy link
Contributor

mattwoodrow commented Dec 18, 2018

…itComposite shader (which doesn't support snapping).

This fixes gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1509428

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=01069308445460e1dc77709d1ec86b6605a6af3e


This change is Reviewable

@gw3583

gw3583 approved these changes Dec 18, 2018

Copy link
Collaborator

gw3583 left a comment

A couple of small nits, otherwise looks good!

Show resolved Hide resolved webrender/src/picture.rs Outdated
Show resolved Hide resolved wrench/reftests/transforms/reftest.list Outdated

@mattwoodrow mattwoodrow force-pushed the mattwoodrow:dont-snap branch 2 times, most recently from 1f79f60 to d45e329 Dec 18, 2018

Don't snap UV coordinates when they are going to be used with the Spl…
…itComposite shader (which doesn't support snapping)

@mattwoodrow mattwoodrow force-pushed the mattwoodrow:dont-snap branch from d45e329 to bac0a04 Dec 18, 2018

@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Dec 18, 2018

@bors-servo delegate+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 18, 2018

✌️ @mattwoodrow can now approve this pull request

@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Dec 18, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 18, 2018

📌 Commit bac0a04 has been approved by gw3583

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 18, 2018

⌛️ Testing commit bac0a04 with merge 10cde54...

bors-servo added a commit that referenced this pull request Dec 18, 2018

Auto merge of #3435 - mattwoodrow:dont-snap, r=gw3583
Don't snap UV coordinates when they are going to be used with the Spl…

…itComposite shader (which doesn't support snapping).

This fixes gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1509428

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=01069308445460e1dc77709d1ec86b6605a6af3e

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3435)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 19, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 10cde54 to master...

@bors-servo bors-servo merged commit bac0a04 into servo:master Dec 19, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 19, 2018

Bug 1515244 - Update webrender to commit 10cde544d9f7f83a31dbedf67db9…
…42f7845982d1 (WR PR #3435). r=kats

servo/webrender#3435

Differential Revision: https://phabricator.services.mozilla.com/D14939

--HG--
extra : moz-landing-system : lando

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment