Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't snap UV coordinates when they are going to be used with the Spl… #3435

Merged
merged 1 commit into from Dec 19, 2018

Conversation

mattwoodrow
Copy link
Contributor

@mattwoodrow mattwoodrow commented Dec 18, 2018

…itComposite shader (which doesn't support snapping).

This fixes gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1509428

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=01069308445460e1dc77709d1ec86b6605a6af3e


This change is Reviewable

Copy link
Contributor

@gw3583 gw3583 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small nits, otherwise looks good!

webrender/src/picture.rs Outdated Show resolved Hide resolved
wrench/reftests/transforms/reftest.list Outdated Show resolved Hide resolved
@mattwoodrow mattwoodrow force-pushed the dont-snap branch 2 times, most recently from 1f79f60 to d45e329 Compare December 18, 2018 22:01
…itComposite shader (which doesn't support snapping)
@gw3583
Copy link
Contributor

gw3583 commented Dec 18, 2018

@bors-servo delegate+

@bors-servo
Copy link
Contributor

✌️ @mattwoodrow can now approve this pull request

@gw3583
Copy link
Contributor

gw3583 commented Dec 18, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit bac0a04 has been approved by gw3583

@bors-servo
Copy link
Contributor

⌛ Testing commit bac0a04 with merge 10cde54...

bors-servo pushed a commit that referenced this pull request Dec 18, 2018
Don't snap UV coordinates when they are going to be used with the Spl…

…itComposite shader (which doesn't support snapping).

This fixes gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1509428

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=01069308445460e1dc77709d1ec86b6605a6af3e

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3435)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 10cde54 to master...

@bors-servo bors-servo merged commit bac0a04 into servo:master Dec 19, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 19, 2018
…42f7845982d1 (WR PR #3435). r=kats

servo/webrender#3435

Differential Revision: https://phabricator.services.mozilla.com/D14939

--HG--
extra : moz-landing-system : lando
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Dec 19, 2018
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
…42f7845982d1 (WR PR #3435). r=kats

servo/webrender#3435

Differential Revision: https://phabricator.services.mozilla.com/D14939

UltraBlame original commit: 6cfb1fdf1ddc001f75b304c219ddb8b3c13dcab7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
…42f7845982d1 (WR PR #3435). r=kats

servo/webrender#3435

Differential Revision: https://phabricator.services.mozilla.com/D14939

UltraBlame original commit: 6cfb1fdf1ddc001f75b304c219ddb8b3c13dcab7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
…42f7845982d1 (WR PR #3435). r=kats

servo/webrender#3435

Differential Revision: https://phabricator.services.mozilla.com/D14939

UltraBlame original commit: 6cfb1fdf1ddc001f75b304c219ddb8b3c13dcab7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants