Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate interning for Line Decoration & Picture #3437

Merged
merged 2 commits into from Dec 19, 2018

Conversation

@djg
Copy link
Contributor

djg commented Dec 18, 2018

The last primitives to be extracted for separate interning. Closes out #3385.


This change is Reviewable

@djg
Copy link
Contributor Author

djg commented Dec 19, 2018

@gw3583 I'm ready for this one to land.

@gw3583
gw3583 approved these changes Dec 19, 2018
Copy link
Collaborator

gw3583 left a comment

Reviewed 10 of 10 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@gw3583
Copy link
Collaborator

gw3583 commented Dec 19, 2018

Looks sane.

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Dec 19, 2018

📌 Commit f8f62d1 has been approved by gw3583

@bors-servo
Copy link
Contributor

bors-servo commented Dec 19, 2018

Testing commit f8f62d1 with merge 3441199...

bors-servo added a commit that referenced this pull request Dec 19, 2018
Separate interning for Line Decoration & Picture

The last primitives to be extracted for separate interning. Closes out #3385.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3437)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 19, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 3441199 to master...

@bors-servo bors-servo merged commit f8f62d1 into servo:master Dec 19, 2018
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
code-review/reviewable 10 files reviewed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@djg djg deleted the djg:separate_interning_rest branch Dec 19, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 19, 2018
…38e34d9922bb (WR PR #3437). r=kats

servo/webrender#3437

Differential Revision: https://phabricator.services.mozilla.com/D14973

--HG--
extra : moz-landing-system : lando
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.