New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix picture caching on sites with multiple scroll roots. #3454

Merged
merged 1 commit into from Dec 31, 2018

Conversation

Projects
None yet
3 participants
@gw3583
Copy link
Collaborator

gw3583 commented Dec 30, 2018

For now, we simply disable picture caching when we encounter a
display list with content that has multiple scroll roots (other
than the root scroll node) - this still handles the majority of
sites. In future, we can expand this to support more cases.


This change is Reviewable

Fix picture caching on sites with multiple scroll roots.
For now, we simply disable picture caching when we encounter a
display list with content that has multiple scroll roots (other
than the root scroll node) - this still handles the majority of
sites. In future, we can expand this to support more cases.
@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Dec 30, 2018

@kvark

kvark approved these changes Dec 31, 2018

Copy link
Member

kvark left a comment

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Dec 31, 2018

@bors-servo r=kvark

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 31, 2018

📌 Commit 6ac04b4 has been approved by kvark

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 31, 2018

⌛️ Testing commit 6ac04b4 with merge ff485fa...

bors-servo added a commit that referenced this pull request Dec 31, 2018

Auto merge of #3454 - gw3583:twitter-fix, r=kvark
Fix picture caching on sites with multiple scroll roots.

For now, we simply disable picture caching when we encounter a
display list with content that has multiple scroll roots (other
than the root scroll node) - this still handles the majority of
sites. In future, we can expand this to support more cases.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3454)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 31, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing ff485fa to master...

@bors-servo bors-servo merged commit 6ac04b4 into servo:master Dec 31, 2018

4 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
code-review/reviewable 1 file reviewed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 1, 2019

Bug 1516810 - Update webrender to commit ff485fa67cc7341b8e7a0d32e377…
…a419e8d252c6 (WR PR #3454). r=kats

servo/webrender#3454

Differential Revision: https://phabricator.services.mozilla.com/D15532

--HG--
extra : moz-landing-system : lando

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Jan 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment