Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] hook up the blob visible area in tile-decomposition #3461
Conversation
…e decomposition algorithm.
The tiling origin is computed in image::tiles instead of being provided to the function. In addition, the image rect in device space is exposed as function parameter. In a followup commit callers will have to determine the correct image rect using the blob image's visible area.
|
|
|
I think we can close this now, and land any remaining parts via m-c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedJan 3, 2019
•
edited by larsbergstrom
Store the blob visible areas in yet another hash map (this one being in the bag of post-scene-building state whereas
blob_image_templatesis pre-scene-building info), and pass it along to the tile decomposition code.This PR needs #3460 and #3409.
This change is