New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blob leak panic in rawtests #3470

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@nical
Copy link
Collaborator

nical commented Jan 4, 2019

When rawtests are run in debug mode we panic towards the end because some blobs were not manually evicted from the texture cache. Some of the tests were not fully cleaning up after themselves and this commit fixes that.


This change is Reviewable

@nical

This comment has been minimized.

Copy link
Collaborator

nical commented Jan 4, 2019

The failure I'm referring to is:

thread 'WRRenderBackend#0' panicked at 'Manual eviction requires cleanup', webrender/src/resource_cache.rs:225:9

r? anyone

@staktrace

This comment has been minimized.

Copy link
Contributor

staktrace commented Jan 4, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 4, 2019

📌 Commit c9cc1d6 has been approved by staktrace

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 4, 2019

⌛️ Testing commit c9cc1d6 with merge e8ef39b...

bors-servo added a commit that referenced this pull request Jan 4, 2019

Auto merge of #3470 - nical:blob-eviction-panic, r=staktrace
Fix blob leak panic in rawtests

When rawtests are run in debug mode we panic towards the end because some blobs were not manually evicted from the texture cache. Some of the tests were not fully cleaning up after themselves and this commit fixes that.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3470)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 4, 2019

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: staktrace
Pushing e8ef39b to master...

@bors-servo bors-servo merged commit c9cc1d6 into servo:master Jan 4, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 4, 2019

Bug 1517742 - Update webrender to commit e8ef39b4499aa93e008a25e851c0…
…1f4dff36b301 (WR PR #3470). r=kats

servo/webrender#3470

Differential Revision: https://phabricator.services.mozilla.com/D15735

--HG--
extra : moz-landing-system : lando

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment