New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some intermittent picture caching test failures. #3478

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@gw3583
Copy link
Collaborator

gw3583 commented Jan 7, 2019

Storing just the world position of the clip vertex can fail in
some edge cases. Instead, store the local origin and a list of
the relative transforms that affect primitive on this tile, which
is also a CPU optimization.

Also reduce the number of pixels blitted during tile creation
by only copying the visible part of the tile.


This change is Reviewable

Fix some intermittent picture caching test failures.
Storing just the world position of the clip vertex can fail in
some edge cases. Instead, store the local origin and a list of
the relative transforms that affect primitive on this tile, which
is also a CPU optimization.

Also reduce the number of pixels blitted during tile creation
by only copying the visible part of the tile.
@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Jan 7, 2019

@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Jan 7, 2019

@bors-servo r=bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 7, 2019

📌 Commit f1c6fc1 has been approved by bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 7, 2019

⌛️ Testing commit f1c6fc1 with merge 1b22653...

bors-servo added a commit that referenced this pull request Jan 7, 2019

Auto merge of #3478 - gw3583:better-tests, r=bholley
Fix some intermittent picture caching test failures.

Storing just the world position of the clip vertex can fail in
some edge cases. Instead, store the local origin and a list of
the relative transforms that affect primitive on this tile, which
is also a CPU optimization.

Also reduce the number of pixels blitted during tile creation
by only copying the visible part of the tile.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3478)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 7, 2019

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: bholley
Pushing 1b22653 to master...

@bors-servo bors-servo merged commit f1c6fc1 into servo:master Jan 7, 2019

2 of 3 checks passed

Taskcluster (pull_request) TaskGroup: Pending (for pull_request.opened)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 7, 2019

Bug 1517975 - Update webrender to commit 1b226534099a24c741e9827c4612…
…eee1ec12d4ee (WR PR #3478). r=kats

servo/webrender#3478

Differential Revision: https://phabricator.services.mozilla.com/D15822

--HG--
extra : moz-landing-system : lando

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment