Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upupdated recording branch #354
Merged
Conversation
metajack
commented
Aug 18, 2016
|
r? @glennw |
webrender/src/record.rs
Outdated
| ref msg @ &ApiMsg::TickScrollingBounce| | ||
| ref msg @ &ApiMsg::DeleteImage(..)| | ||
| ref msg @ &ApiMsg::SetRootStackingContext(..) =>{ | ||
| let filename = format!("record/frame_{}.bin", frame); |
This comment has been minimized.
This comment has been minimized.
glennw
Aug 18, 2016
Member
Can this share code with or directly use the write_data function above? (Just so the filename isn't declared in two locations etc).
|
@alanamramjit One minor issue, then it should be good to go. |
|
You're right; this should probably create a RecordMsg enum so that it's easier to deserialize anyway. |
|
@bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 18, 2016
updated recording branch updated recording infrastructure for #6 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/354) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
lanamorgan commentedAug 18, 2016
•
edited by larsbergstrom
updated recording infrastructure for #6
This change is