Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sha256 from dependencies #3687

Closed
wants to merge 3 commits into from
Closed

Remove sha256 from dependencies #3687

wants to merge 3 commits into from

Conversation

@fschutt
Copy link
Contributor

fschutt commented Jun 26, 2019

  • The shaders are not hashed by their content anymore, only by their file name / their imports - i.e. a shader "a.glsl" that imports "b.glsl" get a unique ID based on the combination ["a.glsl", "b.glsl"] (instead of a SHA hash of the file contents of a.glsl and b.glsl). This also avoids possible collisions.
  • The "program digest" is now just a shader ID, there was a check for checking whether the source of the loaded shader is equal to the source of the included shader (which I thought was fairly useless, since those shaders are always the same, so the check can never fail?). So I've removed that check, but I'm not sure if it had historical reasons.

This is a WIP PR, just to give an update, doesn't compile yet, closes #3586.


This change is Reviewable

@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2019

The latest upstream changes (presumably #3727) made this pull request unmergeable. Please resolve the merge conflicts.

@community-tc-integration

This comment has been minimized.

Copy link

community-tc-integration bot commented on 9d15dd6 Feb 13, 2020

Submitting the task to Taskcluster failed. Details

Taskcluster-GitHub attempted to create a task for this event with the following scopes:

[
  "assume:repo:github.com/servo/webrender:pull-request",
  "queue:route:statuses",
  "queue:scheduler-id:taskcluster-github"
]

The expansion of these scopes is not sufficient to create the task, leading to the following:

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AllOf": [
    "queue:route:index.garbage.webrender.ci.fschutt.remove-sha2.linux-release",
    {
      "AnyOf": [
        {
          "AnyOf": [
            "queue:create-task:highest:unknown/unknown",
            "queue:create-task:very-high:unknown/unknown",
            "queue:create-task:high:unknown/unknown",
            "queue:create-task:medium:unknown/unknown",
            "queue:create-task:low:unknown/unknown",
            "queue:create-task:very-low:unknown/unknown",
            "queue:create-task:lowest:unknown/unknown"
          ]
        },
        {
          "AnyOf": [
            "queue:create-task:unknown/unknown",
            {
              "AllOf": [
                "queue:define-task:unknown/unknown",
                "queue:task-group-id:taskcluster-github/DTmTffzcRQ-WPq6YqW_-2A",
                "queue:schedule-task:taskcluster-github/DTmTffzcRQ-WPq6YqW_-2A/DTmTffzcRQ-WPq6YqW_-2A"
              ]
            }
          ]
        }
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AllOf": [
    "queue:route:index.garbage.webrender.ci.fschutt.remove-sha2.linux-release",
    "queue:route:statuses",
    {
      "AnyOf": [
        {
          "AllOf": [
            "queue:scheduler-id:taskcluster-github",
            {
              "AnyOf": [
                "queue:create-task:highest:unknown/unknown",
                "queue:create-task:very-high:unknown/unknown",
                "queue:create-task:high:unknown/unknown",
                "queue:create-task:medium:unknown/unknown",
                "queue:create-task:low:unknown/unknown",
                "queue:create-task:very-low:unknown/unknown",
                "queue:create-task:lowest:unknown/unknown"
              ]
            }
          ]
        },
        {
          "AnyOf": [
            "queue:create-task:unknown/unknown",
            {
              "AllOf": [
                "queue:define-task:unknown/unknown",
                "queue:task-group-id:taskcluster-github/DTmTffzcRQ-WPq6YqW_-2A",
                "queue:schedule-task:taskcluster-github/DTmTffzcRQ-WPq6YqW_-2A/DTmTffzcRQ-WPq6YqW_-2A"
              ]
            }
          ]
        }
      ]
    }
  ]
}

  • method: createTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2020-02-13T18:39:55.414Z
@fschutt
Copy link
Contributor Author

fschutt commented Feb 13, 2020

PR seems to be borked. I'll create a new one

@fschutt fschutt closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.