Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate glutin to 0.21, winit to 0.19 #3690
Conversation
|
Do I need to fix the duplicate dependencies (crossbeam etc) as reported by Taskcluster? That would make this PR a bit more complex (I don't know how much), but I'd be happy to look into updating them as well. |
I don't know if they'll care about those duplicates but for now you could add them to servo-tidy.toml. |
|
Ah, thanks for pointing me to that file. It says that one of the files I touched is copied from glutin; I should probably copy over glutin 0.21's version of that file (or import the module if it is now public). |
|
|
|
So I looked at that file and it's not as easy as copying egl.rs, it imports private items from glutin. I'll leave the file as it is until I get further feedback. |
|
Rebased and put the duplicate deps in the ignore list in servo-tidy.toml Like I said before, I'd be happy to investigate how to get rid of the duplicate dependencies instead, if that is preferred. |
|
@jplatte AppVeyor isn't happy. Could you fix this? |
…lContext
|
@kvark: done |
|
Imported as https://phabricator.services.mozilla.com/D36978 |
From servo/webrender#3690 Differential Revision: https://phabricator.services.mozilla.com/D36978 --HG-- extra : moz-landing-system : lando
From servo/webrender#3690 Differential Revision: https://phabricator.services.mozilla.com/D36978
From servo#3690 Differential Revision: https://phabricator.services.mozilla.com/D36978 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/87a8c6317e12e1f2a7daf4b08d9935f6f610e7d0
|
This was merged in #3699. Thanks! |
From servo/webrender#3690 Differential Revision: https://phabricator.services.mozilla.com/D36978 UltraBlame original commit: 87a8c6317e12e1f2a7daf4b08d9935f6f610e7d0
From servo/webrender#3690 Differential Revision: https://phabricator.services.mozilla.com/D36978 UltraBlame original commit: 87a8c6317e12e1f2a7daf4b08d9935f6f610e7d0
From servo/webrender#3690 Differential Revision: https://phabricator.services.mozilla.com/D36978 UltraBlame original commit: 87a8c6317e12e1f2a7daf4b08d9935f6f610e7d0
jplatte commentedJul 2, 2019
•
edited by larsbergstrom
Resolves #3612
Supersedes #3546
This change is