Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central #3762

Merged
merged 2 commits into from Sep 24, 2019
Merged

Sync changes from mozilla-central #3762

merged 2 commits into from Sep 24, 2019

Conversation

@moz-gfx
Copy link

moz-gfx commented Sep 24, 2019

This change is Reviewable

nical and others added 2 commits Sep 24, 2019
Adds a module documentation in segment.rs giving an overview of the role of primitive segments and how they interact with clipping. Also reformatted the clip.rs documentation to play well with rustdoc.

Differential Revision: https://phabricator.services.mozilla.com/D46472

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/e26a0b6e6f60819faaba933f91bf35fbfd9d5c7d
…l rect. r=kvark,gw

As it turns out, the difference between the snapped local rect and the
unsnapped local rect was not just that the former contained snapped
primitives and the latter contained unsnapped primitives, but also that
the former took into account surface inflation for primitives, the
entire clip chain instead of just the primitive's local clip, and
removal of culled primitives. As such, the picture's rects can be wildly
different, even if snapping has been taken care of earlier, and parts of
WebRender have come to rely upon this more accurate representation of a
picture.

Differential Revision: https://phabricator.services.mozilla.com/D46605

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/96ce8d267d27ed5a0b0b9cd7e105dcf90010d78f
@moz-gfx
Copy link
Author

moz-gfx commented Sep 24, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2019

📌 Commit 855a7d8 has been approved by moz-gfx

bors-servo added a commit that referenced this pull request Sep 24, 2019
Sync changes from mozilla-central
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2019

Testing commit 855a7d8 with merge 71ed8e7...

@ghost
Copy link

ghost commented Sep 24, 2019

Submitting the task to Taskcluster failed. Details

Cannot read property 'length' of undefined

@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2019

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: moz-gfx
Pushing 71ed8e7 to master...

@bors-servo bors-servo merged commit 855a7d8 into servo:master Sep 24, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@ghost
Copy link

ghost commented Sep 24, 2019

Submitting the task to Taskcluster failed. Details

Cannot read property 'length' of undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.