Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central #3764
Merged
Conversation
…colors to be explicitly specified. r=gw The current code doesn't permit fully opaque debug rects. Differential Revision: https://phabricator.services.mozilla.com/D47154 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/90162306864cefa2889b2fe56701c8149ea25433
This approach does have some stacking issues. The way to fix this would be to instrument the brush_image shader rather than adding debug rects. Something like: #ifdef WR_FEATURE_SFW frag.color = vec4(0,1,1,1); #endif That's slightly more involved though, so I'm going to leave it for now. Differential Revision: https://phabricator.services.mozilla.com/D47155 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/f59ec3966f5f3242b18a188b52217496ec65b42a
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 26, 2019
Sync changes from mozilla-central
ghost
commented
Sep 26, 2019
Submitting the task to Taskcluster failed. DetailsCannot read property 'length' of undefined |
|
|
ghost
commented
Sep 26, 2019
Submitting the task to Taskcluster failed. DetailsCannot read property 'length' of undefined |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedSep 26, 2019
•
edited by larsbergstrom
This change is