Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central #3765

Merged
merged 6 commits into from Sep 28, 2019
Merged

Sync changes from mozilla-central #3765

merged 6 commits into from Sep 28, 2019

Conversation

@moz-gfx
Copy link

moz-gfx commented Sep 26, 2019

This change is Reviewable

Glenn Watson and others added 2 commits Sep 26, 2019
…icture cache slices r=nical,kvark

Previously, the setup_picture_caching function was hard coded
to support only a very specific shape of display list. With this
change, flags are added to PrimitiveCluster that can specify
if a picture cache slice should be created before / after this
cluster when picture caching is set up.

The usage of these flags in this patch matches the old behaviour,
so should not have any functional effect.

However, in future we will make use of this functionality to
create picture slices for a number of different use cases, such as:

 * Creating cache tiles for the UI.
 * Slicing the scene where there are video elements, in order to
   allow these to be composited directly by the OS. This may also
   apply to WebGL and/or canvas elements.
 * Slicing the scene when there is a very large fixed position
   background image or other element, to avoid invalidating the
   entire tile cache each frame.

Differential Revision: https://phabricator.services.mozilla.com/D46125

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/c2c9dbf826fe7b81bc8535988d2a48570a43c7e3
@moz-gfx
Copy link
Author

moz-gfx commented Sep 26, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Sep 26, 2019

📌 Commit 81cfc62 has been approved by moz-gfx

@bors-servo
Copy link
Contributor

bors-servo commented Sep 26, 2019

Testing commit 81cfc62 with merge 1175bce...

bors-servo added a commit that referenced this pull request Sep 26, 2019
Sync changes from mozilla-central
@ghost
Copy link

ghost commented Sep 26, 2019

Submitting the task to Taskcluster failed. Details

Cannot read property 'length' of undefined

@bors-servo
Copy link
Contributor

bors-servo commented Sep 26, 2019

💔 Test failed - status-appveyor

Kris Taeleman and others added 2 commits Sep 27, 2019
…icture cache slices r=nical,kvark

Previously, the setup_picture_caching function was hard coded
to support only a very specific shape of display list. With this
change, flags are added to PrimitiveCluster that can specify
if a picture cache slice should be created before / after this
cluster when picture caching is set up.

The usage of these flags in this patch matches the old behaviour,
so should not have any functional effect.

However, in future we will make use of this functionality to
create picture slices for a number of different use cases, such as:

 * Creating cache tiles for the UI.
 * Slicing the scene where there are video elements, in order to
   allow these to be composited directly by the OS. This may also
   apply to WebGL and/or canvas elements.
 * Slicing the scene when there is a very large fixed position
   background image or other element, to avoid invalidating the
   entire tile cache each frame.

Differential Revision: https://phabricator.services.mozilla.com/D46125

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/fc39374e708f30428d1a18c1c93b5fc089cc782b
@moz-gfx
Copy link
Author

moz-gfx commented Sep 27, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2019

📌 Commit 0032f83 has been approved by moz-gfx

@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2019

Testing commit 0032f83 with merge 366c9ab...

bors-servo added a commit that referenced this pull request Sep 27, 2019
Sync changes from mozilla-central

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3765)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2019

💔 Test failed - status-appveyor

To support NDK r20, wrench needs to be built with a more recent, upstream
(though still unpublished) version of cargo-apk. This has some consequences
which have been adjusted for:
 * Gradle is no longer required to build wrench.
 * The output apk file paths have changed.
 * The apks are now signed automatically.
 * The default activity name has changed.
 * Android permissions must be explicitly requested.
 * We must ensure winit is built with a matching version of android_glue.

Differential Revision: https://phabricator.services.mozilla.com/D47129

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/34ab960f8d33ccc5d0640a6eb8d1c2d5715824c1
@moz-gfx
Copy link
Author

moz-gfx commented Sep 27, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2019

📌 Commit 88e82d7 has been approved by moz-gfx

@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2019

Testing commit 88e82d7 with merge 16879c1...

bors-servo added a commit that referenced this pull request Sep 27, 2019
Sync changes from mozilla-central

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3765)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2019

💔 Test failed - status-appveyor

@moz-gfx
Copy link
Author

moz-gfx commented Sep 28, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2019

📌 Commit c426973 has been approved by moz-gfx

@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2019

Testing commit c426973 with merge 41cb19f...

bors-servo added a commit that referenced this pull request Sep 28, 2019
Sync changes from mozilla-central

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3765)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2019

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: moz-gfx
Pushing 41cb19f to master...

@bors-servo bors-servo merged commit c426973 into servo:master Sep 28, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@ghost
Copy link

ghost commented Sep 28, 2019

Submitting the task to Taskcluster failed. Details

tasks field of .taskcluster.yml must be array of tasks or empty array

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.