Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central #3769
Merged
Conversation
added 2 commits
Oct 3, 2019
… r=emilio Differential Revision: https://phabricator.services.mozilla.com/D47856 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/764a1d773a1049ffbbcff0c7fbb6a11f3c0e798d
Previously, picture cache tiles were added to normal batches, and drawn via the brush_image shader. Since all content is now in picture cache tiles, we can instead draw the tiles via a separate code path. The tiles for all picture caches are collected into a single composite config, that is stored in the Frame structure. These two changes provide a number of advantages: * The composite shader is very simple - it doesn't need to deal with transforms, anti-aliasing, repetition etc. * Since we create the tile batches in render(), rather than in the backend, we can take advantage of information not available until the render() call. For example, Gecko will provide information here when the partial presentation rects need to be reset. This will be used to enable partial presentation parameters on Windows. * In future, we can access this list of tiles to be composited, and use them to configure the OS compositor integration, and hand the tiles directly to the OS compositor. * In future, we can apply global optimizations to the set of picture cache tiles (e.g. occlude background tiles on CPU to skip paying the z-reject cost of drawing them). * In future, we can take advantage of the simpler composite path for software rasterizer implementations. Differential Revision: https://phabricator.services.mozilla.com/D47724 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/845c92fd34a67a3924abf7341224279c02fbab24
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 3, 2019
Sync changes from mozilla-central
|
|
We need to detect this code path in renderer, and call the legacy draw_color_target method. Differential Revision: https://phabricator.services.mozilla.com/D48105 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/46c1d4bde8d44e821ad01e39aae82b4ae7f72f2d
|
@bors-servo r+ |
|
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 4, 2019
Sync changes from mozilla-central <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3769) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedOct 3, 2019
•
edited by larsbergstrom
This change is