Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central #3771
Merged
Conversation
and others
added 3 commits
Oct 9, 2019
The framebuffer clear was accidentally removed due to a rebase error. We need to clear the framebuffer (and z) here when the non-picture caching path is active. Differential Revision: https://phabricator.services.mozilla.com/D48600 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/6338cf051cbb48a83f836be063a1dcfc5936033f
…ulator error. r=gw When uploading texture data with a PBO we currently ensure the PBO is the size of `(height - 1) * stride + (width * bpp)`, ie the final row only contains the width's worth of data, not the stride. This should be okay, and works fine on other implementations, but the android emulator thinks it is invalid and emits a GL_INVALID_OPERATION error in the glTexSubImage* call. To avoid this, ensure that the PBO is the full `height * stride` size. Differential Revision: https://phabricator.services.mozilla.com/D48541 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/ca08f015b43046a0bde5eda45bcf307a82ae1724
Depends on D48541 Differential Revision: https://phabricator.services.mozilla.com/D48542 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/ac3bcdd939b430cf82492c342f13038509d1387c
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 9, 2019
Sync changes from mozilla-central
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedOct 9, 2019
•
edited by larsbergstrom
This change is