Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central #3782

Merged
merged 5 commits into from Oct 29, 2019
Merged

Sync changes from mozilla-central #3782

merged 5 commits into from Oct 29, 2019

Conversation

@moz-gfx
Copy link

moz-gfx commented Oct 28, 2019

No description provided.

Glenn Watson and others added 2 commits Oct 28, 2019
With this patch, picture cache slices are constructed each time
a new scroll root is established. This reduces rasterization
cost on pages that have large fixed position elements, and pages
that contain multiple scroll roots.

Differential Revision: https://phabricator.services.mozilla.com/D50026

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/60e6c61a7f455624b2ef0702d1925f8d8303bb38
…ebRender r=gw

EGL_ANGLE_experimental_present_path was enabled for fast rendering to SwapChain by ANGLE. But current gecko does not request ANGLE to render to SwapChain for WebRender. Then we do not need to use EGL_ANGLE_experimental_present_path anymore. But Its usage still has a side effect that y is flipped. But OS compositor implementation on Windows does not want it. And it seems not good to continue to use EGL_ANGLE_experimental_present_path since it is experimental feature.

But when EGL_ANGLE_experimental_present_path is removed, rendering result of frame buffer is y flipped with ANGLE compared to other OpenGL implementation. It needs to be handled in WR. It is similar to chromium.

Differential Revision: https://phabricator.services.mozilla.com/D50604

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/9277be3613ca5109ae4007a512ee75856f8f1120
@moz-gfx
Copy link
Author

moz-gfx commented Oct 28, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Oct 28, 2019

📌 Commit 4c0f59d has been approved by moz-gfx

bors-servo added a commit that referenced this pull request Oct 28, 2019
Sync changes from mozilla-central
@bors-servo
Copy link
Contributor

bors-servo commented Oct 28, 2019

Testing commit 4c0f59d with merge f94d98e...

@bors-servo
Copy link
Contributor

bors-servo commented Oct 28, 2019

💔 Test failed - status-appveyor

Glenn Watson added 3 commits Oct 29, 2019
… native compositing. r=kvark

This patch is a small refactor of the public and internal structures
for options related to partial present and native compositing. It
doesn't contain any functional changes.

It adds a field to the native compositing setup to allow clients to
express whether dirty rect updates are supported when native compositing
is enabled (not currently used but will be enabled soon).

It also removes the partial present config options, and makes them
part of the default / draw compositing mode.

Differential Revision: https://phabricator.services.mozilla.com/D50521

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/58527612bae7e266dc6bff0f9b7298304b3899a1
…terface. r=mstange

Platform differences between DirectComposition and CoreAnimation
mean that WR needs to bind the FBO ID that the underlying platform
returns as part of the surface binding operation.

Differential Revision: https://phabricator.services.mozilla.com/D50760

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/4697bcd0537b211a8e5849743a77e9ec7e1a7679
…s. r=kvark,mstange

This passes the existing dirty rect for a picture cache update
through the native compositor interface, allowing compositors
to only update a sub-rect of a tile.

Also update the example to pass dirty rect to DirectComposition,
and add debug drawing for compositor redraw region.

Differential Revision: https://phabricator.services.mozilla.com/D50767

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/da9cbdbdfcbf74ba8f995e54803ab9fcfd1b3552
@moz-gfx
Copy link
Author

moz-gfx commented Oct 29, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2019

📌 Commit ecde94b has been approved by moz-gfx

@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2019

Testing commit ecde94b with merge 918df6b...

bors-servo added a commit that referenced this pull request Oct 29, 2019
Sync changes from mozilla-central
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2019

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: moz-gfx
Pushing 918df6b to master...

@bors-servo bors-servo merged commit ecde94b into servo:master Oct 29, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.