Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central #3789
Merged
Conversation
and others
added 3 commits
Nov 1, 2019
…otaro - When partial present is not valid, ensure that a single dirty rect the entire size of the framebuffer is returned. - Ensure that we never return an empty dirty rect. If nothing is dirty, the returned dirty rects array is empty, which can be used by the client to completely skip calling Present. - Remove partial present Multi mode (for now). This mode has some issues with overlapping tiles which can be resolved as a follow up. This should allow enabling partial present for a single dirty rect, which covers most common cases. We can re-implement the more complicated Multi partial present mode if / when we find pages where supporting multiple partial present rects is a good win. Differential Revision: https://phabricator.services.mozilla.com/D51332 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/9c9fffed78e5aa1ff3a945755a3c28d93c6e1373
A bug in the android emulator means that glTexImage3D thinks the maximum texture size is the value of GL_MAX_TEXTURE_SIZE, rather than the value returned by glGetIntegerv(GL_MAX_TEXTURE_SIZE). This means that calls to glTexImage3D fail when width, height, or depth > 3379. This forces us to use glTexStorage3D instead of glTexImage3D, avoiding this bug. This relies upon swizzling, which is indeed supported on the android emulator. Differential Revision: https://phabricator.services.mozilla.com/D51293 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/f39fa8f0265d5a86d452c589ac88455ce7295fcc
…ated on android emulator. r=gw The emulator's implementation of glShaderSource can crash if the source string are not null-terminated, even though we correctly pass the lengths of the strings. Work around this by adding a null terminator when running on the emulator. Depends on D51293 Differential Revision: https://phabricator.services.mozilla.com/D51294 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/17366ca83b0c964f0b413ddd76229a768660d9e5
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 1, 2019
Sync changes from mozilla-central
|
|
…e display port but not currently visible. r=nical Previously, WR needed to update and track dependencies for all allocated picture cache tiles in the virtual display port. This means doing extra CPU work (dependency updates) and in some cases, extra GPU work (larger off-screen child surfaces) than are strictly required. With this patch, each tile determines if it is currently visible in pre_update. If the tile isn't visible, we skip doing dependency updates until it is on screen again. More importantly, this is used to reduce the world culling rect for primitive preparation, which also means large child surfaces only require allocations large enough to enclose the visible tiles, rather than the display port. Differential Revision: https://phabricator.services.mozilla.com/D51006 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/d0f88eadd0f583df0e805409c8158bfa6f826d92
|
@bors-servo r+ |
|
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 3, 2019
Sync changes from mozilla-central
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedNov 1, 2019
No description provided.