Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central #3792

Merged
merged 8 commits into from Nov 6, 2019
Merged

Sync changes from mozilla-central #3792

merged 8 commits into from Nov 6, 2019

Conversation

@moz-gfx
Copy link

moz-gfx commented Nov 5, 2019

No description provided.

@moz-gfx
Copy link
Author

moz-gfx commented Nov 5, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2019

📌 Commit 5ffb2e7 has been approved by moz-gfx

@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2019

Testing commit 5ffb2e7 with merge f19f4c8...

bors-servo added a commit that referenced this pull request Nov 5, 2019
Sync changes from mozilla-central
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2019

💔 Test failed - status-appveyor

aosmond and others added 4 commits Nov 5, 2019
…y. r=lsalzman

The glyph pixel space in which we rasterized glyphs differed from how we
rendered the rasterized glyphs in the shader. They need to be in
agreement because the glyph subpixel offset selected during
rasterization depends on it. This patch should make the paths consistent
with each other.

Additionally, during animations, we now snap the reference frame
relative offset ignoring the impact of any animated transforms. This
helps with minimizing glyph wiggling during the transition.

Differential Revision: https://phabricator.services.mozilla.com/D51305

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/4c4b65f3e7fb6cd86d222f7f5bb0bfb8290b6b0d
@moz-gfx
Copy link
Author

moz-gfx commented Nov 5, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2019

📌 Commit eaea697 has been approved by moz-gfx

@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2019

Testing commit eaea697 with merge 12ad79f...

bors-servo added a commit that referenced this pull request Nov 5, 2019
Sync changes from mozilla-central
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2019

💔 Test failed - status-appveyor

@jrmuizel
Copy link
Contributor

jrmuizel commented Nov 5, 2019

C:\fakepath(1753,25-29): error X4576: Input array signature parameter SV_Position cannot be indexed dynamically.
@kvark
Copy link
Member

kvark commented Nov 6, 2019

@jrmuizel we need that on CI...

@moz-gfx
Copy link
Author

moz-gfx commented Nov 6, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2019

📌 Commit 9c0f230 has been approved by moz-gfx

@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2019

Testing commit 9c0f230 with merge 1fb5156...

bors-servo added a commit that referenced this pull request Nov 6, 2019
Sync changes from mozilla-central
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2019

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: moz-gfx
Pushing 1fb5156 to master...

@bors-servo bors-servo merged commit 9c0f230 into servo:master Nov 6, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.