Sync changes from mozilla-central #3794

moz-gfx · 2019-11-06T22:03:33Z

No description provided.


        Bug 1594091 - Move user_data to the glyph instance w field. r=gw

First patch in of series that will rearrange the layout of the glyph instance attributes so that it matches brush instances. This will be needed to add a unified shader that can render the most common alpha pass primitives, including text. Differential Revision: https://phabricator.services.mozilla.com/D51879 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/570d5ec05d035d9fb156c8cc336ad66885b21de6


        Bug 1594091 - Move color_mode and subpx_dir to the first half of the …

…glyph instance z field. r=gw Depends on D51879 Differential Revision: https://phabricator.services.mozilla.com/D51880 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/e405048af859fb0b8aca0060ac8c0df5388ee630


        Bug 1594091 - Move glyph_index to the second half of the glyph instan…

…ce z field. r=gw Depends on D51880 Differential Revision: https://phabricator.services.mozilla.com/D51882 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/047d8fd366a4f92f165244e9de598b0890c3dacd


        Bug 1594091 - Move clip_task_address to the second half of the glyph …

…instance y field. r=gw Depends on D51882 Differential Revision: https://phabricator.services.mozilla.com/D51883 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/c86523dab3c48d8185787f09338b57efeb3f86b0


        Bug 1594091 - Unify text and brush instance attribute decoding. r=gw

Depends on D51883 Differential Revision: https://phabricator.services.mozilla.com/D51884 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/f4b58dd6ef384634dc04b1a462e46d6ae246286a


        Bug 1594091 - Rename the instance user_data field into specific_resou…

…rce_address. r=gw This user_data field is currently only used as an address for some shader-specific resource in the gpu cache. We can always rename it back to something generic if we ever need to use the bits differently in other shaders in the future. Depends on D51884 Differential Revision: https://phabricator.services.mozilla.com/D51885 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/cd13f04835f4d9ebdfccd14b5f4afe6a8a8a2dbe


        Bug 1575258 - Make text rasterize, render and snap glyphs consistentl…

…y. r=lsalzman The glyph pixel space in which we rasterized glyphs differed from how we rendered the rasterized glyphs in the shader. They need to be in agreement because the glyph subpixel offset selected during rasterization depends on it. This patch should make the paths consistent with each other. Additionally, during animations, we now snap the reference frame relative offset ignoring the impact of any animated transforms. This helps with minimizing glyph wiggling during the transition. Differential Revision: https://phabricator.services.mozilla.com/D51305 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/1e12f9b1812772fee75f80a38fd27b5fff8cffbc


        Bug 1593929 - Make invalidate_rendered_frame triggers force redraw r=…

…nical Invalidate_rendered_frame expects full rendering in next WR rendering. Then when invalidate_rendered_frame is requested, we need to request force redraw. Otherwise, SwapChain might skip present call during partial present. Differential Revision: https://phabricator.services.mozilla.com/D51784 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/8189d25586fb6dd2d8e4f5bafbc43a1e31f4988e

moz-gfx · 2019-11-06T22:03:34Z

@bors-servo r+

bors-servo · 2019-11-06T22:03:35Z

📌 Commit 52cfe18 has been approved by moz-gfx

community-tc-integration · 2019-11-06T22:03:36Z

Submitting the task to Taskcluster failed. Details

Taskcluster-GitHub attempted to create a task for this event with the following scopes:

[
  "assume:repo:github.com/servo/webrender:pull-request",
  "queue:route:statuses",
  "queue:scheduler-id:taskcluster-github"
]

The expansion of these scopes is not sufficient to create the task, leading to the following:

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AllOf": [
    "queue:route:index.garbage.webrender.ci.moz-gfx.wrupdater.linux-release",
    {
      "AnyOf": [
        {
          "AnyOf": [
            "queue:create-task:highest:aws-provisioner-v1/github-worker",
            "queue:create-task:very-high:aws-provisioner-v1/github-worker",
            "queue:create-task:high:aws-provisioner-v1/github-worker",
            "queue:create-task:medium:aws-provisioner-v1/github-worker",
            "queue:create-task:low:aws-provisioner-v1/github-worker",
            "queue:create-task:very-low:aws-provisioner-v1/github-worker",
            "queue:create-task:lowest:aws-provisioner-v1/github-worker"
          ]
        },
        {
          "AnyOf": [
            "queue:create-task:aws-provisioner-v1/github-worker",
            {
              "AllOf": [
                "queue:define-task:aws-provisioner-v1/github-worker",
                "queue:task-group-id:taskcluster-github/JBafT5ZyRCCDmoq37XBqtQ",
                "queue:schedule-task:taskcluster-github/JBafT5ZyRCCDmoq37XBqtQ/GJTn_dLUROCqLpQIcQzHxA"
              ]
            }
          ]
        }
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AllOf": [
    "queue:route:index.garbage.webrender.ci.moz-gfx.wrupdater.linux-release",
    "queue:route:statuses",
    {
      "AnyOf": [
        {
          "AllOf": [
            "queue:scheduler-id:taskcluster-github",
            {
              "AnyOf": [
                "queue:create-task:highest:aws-provisioner-v1/github-worker",
                "queue:create-task:very-high:aws-provisioner-v1/github-worker",
                "queue:create-task:high:aws-provisioner-v1/github-worker",
                "queue:create-task:medium:aws-provisioner-v1/github-worker",
                "queue:create-task:low:aws-provisioner-v1/github-worker",
                "queue:create-task:very-low:aws-provisioner-v1/github-worker",
                "queue:create-task:lowest:aws-provisioner-v1/github-worker"
              ]
            }
          ]
        },
        {
          "AnyOf": [
            "queue:create-task:aws-provisioner-v1/github-worker",
            {
              "AllOf": [
                "queue:define-task:aws-provisioner-v1/github-worker",
                "queue:task-group-id:taskcluster-github/JBafT5ZyRCCDmoq37XBqtQ",
                "queue:schedule-task:taskcluster-github/JBafT5ZyRCCDmoq37XBqtQ/GJTn_dLUROCqLpQIcQzHxA"
              ]
            }
          ]
        }
      ]
    }
  ]
}

method: createTask
errorCode: InsufficientScopes
statusCode: 403
time: 2019-11-06T22:03:36.242Z

bors-servo · 2019-11-06T22:03:39Z

⌛ Testing commit 52cfe18 with merge a65441c...


        Auto merge of #3794 - moz-gfx:wrupdater, r=moz-gfx

Sync changes from mozilla-central

bors-servo · 2019-11-07T08:03:39Z

💥 Test timed out


        Bug 1594305 - Only allocate compositor surfaces for tiles that are no…

…t occluded r=nical Tiles that are occluded are generally never seen, or only seen occasionally. To reduce the number of compositor surfaces: * Defer native surface allocation until after occlusion culling occurs. * If a tile has a native surface, then becomes occluded, drop the surface. With this scheme, the number of unused native surfaces will always be 0 on a page that doesn't have scrolling. For a page that has a scrollable region, there will be a small number of unused tiles retained. The unused tiles are those that are (a) not occluded (b) not currently visible (c) are in the display port. We retain these for a small amount of time in case they get scrolled back on screen. This makes the allocation patterns for native surfaces match the way that picture cache surfaces are allocated for simple compositing mode. Differential Revision: https://phabricator.services.mozilla.com/D51973 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/70442369cd48e37b05d2982f4109622cf8209bc6


        Bug 1594524 - Move the call to gpu_profile.end_frame() up so that we …

…don't measure debug overlays. r=gw Differential Revision: https://phabricator.services.mozilla.com/D52090 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/455d161a3fa92006c59f6411e3e01ccabb3c7074


        Bug 1589666 - Disable picture caching whilst pinch-zooming. r=gw

Whilst pinch zooming, every picture cache tile gets completely invalidated every frame. It is therefore a waste of memory bandwidth to render in to picture cache tiles then composite those to the screen. This change dynamically disables picture caching for frames in which we are pinch zooming. The exception is if we are using a native compositor, in which case picture caching will remain enabled, because it relies on picture caching to work, and does not waste memory bandwidth. Differential Revision: https://phabricator.services.mozilla.com/D52017 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/dd0e1c0d6acc4b7cb8b8b251aa3da7984f8b496f


        Backed out changeset 455d161a3fa9 (bug 1594524) for causing Wrench fa…

…ilure in adb wait-for-device shell cat /sys/class/power_supply/battery/input_suspend 2>/dev/null. CLOSED TREE [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/b53c2535ec7da21a0046cc362263b741613c387d


        Bug 1571972 - Re-export RendererError as a public type r=jrmuizel

Differential Revision: https://phabricator.services.mozilla.com/D51897 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/f2a5d56c886dd7f31aaebfcf6016539aa1d5d42f


        Bug 1575648 - Migrate from taskcluster.net to tools.community-tc.serv…

…ices.mozilla.com r=jrmuizel [import_pr] From #3793 Differential Revision: https://phabricator.services.mozilla.com/D52103 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/1e710184eb57d8decb388aee8efdac082d9b48a1


        Bug 1594567 - Fix occluder clip rects for off-screen picture caches. …

…r=kvark Differential Revision: https://phabricator.services.mozilla.com/D52108 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/ecccc6021b088d35a1b7ee9c09090295605b3e21

moz-gfx · 2019-11-07T10:01:41Z

@bors-servo r+

bors-servo · 2019-11-07T10:01:42Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

bors-servo · 2019-11-07T10:01:43Z

📌 Commit b998c39 has been approved by moz-gfx

bors-servo · 2019-11-07T10:01:49Z

⌛ Testing commit b998c39 with merge d3670f7...


        Auto merge of #3794 - moz-gfx:wrupdater, r=moz-gfx

Sync changes from mozilla-central

jdm · 2019-11-07T14:16:25Z

@bors-servo retry

bors-servo · 2019-11-07T14:16:30Z

⌛ Testing commit b998c39 with merge b842e10...


        Auto merge of #3794 - moz-gfx:wrupdater, r=moz-gfx

Sync changes from mozilla-central

jrmuizel · 2019-11-07T14:32:52Z

This got broke by rust 1.39 which just so happened to come out now.

bors-servo · 2019-11-07T15:56:40Z

💔 Test failed - status-appveyor


        Bug 1585713 - don't prune WR glyphs that were recently used. r=jnicol

Differential Revision: https://phabricator.services.mozilla.com/D51340 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/e517398d7ab9a17f721e5940037fbed56717557d


        Bug 1585713 - disable subpixel positioning for oversized WR fonts. r=…

…jnicol Differential Revision: https://phabricator.services.mozilla.com/D51746 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/3479e57e405a9b3b97acc25f76ab4797b0994e84


        Bug 1585713 - reduce WR font size limit from 512 to 320. r=jnicol

Differential Revision: https://phabricator.services.mozilla.com/D51747 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/613cdbb8111686c8be0b9a6e90b2bd92899226f0


        Bug 1594747. Update bitflags in WebRender to 1.2. r=kvark

This will help with some warnings about try! Differential Revision: https://phabricator.services.mozilla.com/D52176 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/cc5ba185000817048946121942490e3409d554c5

moz-gfx · 2019-11-08T05:37:57Z

@bors-servo r+

bors-servo · 2019-11-08T05:37:59Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

bors-servo · 2019-11-08T05:37:59Z

📌 Commit 3313bb3 has been approved by moz-gfx

bors-servo · 2019-11-08T05:38:04Z

⌛ Testing commit 3313bb3 with merge 6e056a2...


        Auto merge of #3794 - moz-gfx:wrupdater, r=moz-gfx

Sync changes from mozilla-central

SimonSapin · 2019-11-08T11:22:53Z

Temporarily removing RUSTFLAGS='--deny warnings' in CI configuration could be a way to unblock this until a proper fix lands in https://bugzilla.mozilla.org/show_bug.cgi?id=1564873

petemoore · 2019-11-08T14:07:52Z

Temporarily removing RUSTFLAGS='--deny warnings' in CI configuration could be a way to unblock this until a proper fix lands in https://bugzilla.mozilla.org/show_bug.cgi?id=1564873

Thanks @SimonSapin!

I'm landing https://lando.services.mozilla.com/D52360/ (currently queued), so hopefully it should get merged back here soon.


        Bug 1594500 - Document the memory layout of brush vertex shaders. r=gw

Differential Revision: https://phabricator.services.mozilla.com/D52138 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/b7d3f7bb8f7c4a43392673bfb26e1efcfe438b55

moz-gfx · 2019-11-08T17:42:45Z

@bors-servo r+

bors-servo · 2019-11-08T17:42:47Z

💡 This pull request was already approved, no need to approve it again.

This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

bors-servo · 2019-11-08T17:42:48Z

📌 Commit 81159b7 has been approved by moz-gfx

bors-servo · 2019-11-08T17:42:52Z

⌛ Testing commit 81159b7 with merge a27d2cf...


        Auto merge of #3794 - moz-gfx:wrupdater, r=moz-gfx

Sync changes from mozilla-central

petemoore · 2019-11-08T20:36:11Z

Note, when https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c61c05f3707767aaf77f7cffa741c86ef44ace2d completes, I'm hoping the Community-TC (pull request) task will pass.


        Bug 1575648 - don't set RUSTFLAGS='--deny warnings' (temporary fix) r…

…=nical This change is a temporary fix to not set RUSTFLAGS='--deny warnings' in order to unblock https://bugzil.la/1575648 (which is time-critical). The longer term solution for this is https://bugzil.la/1564873. Differential Revision: https://phabricator.services.mozilla.com/D52360 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/c61c05f3707767aaf77f7cffa741c86ef44ace2d

moz-gfx · 2019-11-08T21:44:01Z

@bors-servo r+

bors-servo · 2019-11-08T21:44:02Z

💡 This pull request was already approved, no need to approve it again.

This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

bors-servo · 2019-11-08T21:44:03Z

📌 Commit 7971c99 has been approved by moz-gfx

bors-servo · 2019-11-08T21:44:06Z

⌛ Testing commit 7971c99 with merge ec4f5e7...


        Auto merge of #3794 - moz-gfx:wrupdater, r=moz-gfx

Sync changes from mozilla-central

bors-servo · 2019-11-08T23:03:03Z

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: moz-gfx
Pushing ec4f5e7 to master...

nical and others added 8 commits Nov 6, 2019

Bug 1594091 - Move glyph_index to the second half of the glyph instan…

dc1a52f

…ce z field. r=gw Depends on D51880 Differential Revision: https://phabricator.services.mozilla.com/D51882 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/047d8fd366a4f92f165244e9de598b0890c3dacd

Bug 1594091 - Unify text and brush instance attribute decoding. r=gw

8d76cbd

Depends on D51883 Differential Revision: https://phabricator.services.mozilla.com/D51884 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/f4b58dd6ef384634dc04b1a462e46d6ae246286a

Glenn Watson and others added 7 commits Nov 7, 2019

Bug 1594524 - Move the call to gpu_profile.end_frame() up so that we …

ac56990

…don't measure debug overlays. r=gw Differential Revision: https://phabricator.services.mozilla.com/D52090 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/455d161a3fa92006c59f6411e3e01ccabb3c7074

Backed out changeset 455d161a3fa9 (bug 1594524) for causing Wrench fa…

2ab35cf

…ilure in adb wait-for-device shell cat /sys/class/power_supply/battery/input_suspend 2>/dev/null. CLOSED TREE [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/b53c2535ec7da21a0046cc362263b741613c387d

Bug 1571972 - Re-export RendererError as a public type r=jrmuizel

4285877

Differential Revision: https://phabricator.services.mozilla.com/D51897 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/f2a5d56c886dd7f31aaebfcf6016539aa1d5d42f

Bug 1594567 - Fix occluder clip rects for off-screen picture caches. …

Loading status checks…

b998c39

…r=kvark Differential Revision: https://phabricator.services.mozilla.com/D52108 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/ecccc6021b088d35a1b7ee9c09090295605b3e21

Lee Salzman and others added 4 commits Nov 8, 2019

Bug 1585713 - don't prune WR glyphs that were recently used. r=jnicol

67f4e53

Differential Revision: https://phabricator.services.mozilla.com/D51340 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/e517398d7ab9a17f721e5940037fbed56717557d

Bug 1585713 - disable subpixel positioning for oversized WR fonts. r=…

bc865e4

…jnicol Differential Revision: https://phabricator.services.mozilla.com/D51746 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/3479e57e405a9b3b97acc25f76ab4797b0994e84

Bug 1585713 - reduce WR font size limit from 512 to 320. r=jnicol

363617d

Differential Revision: https://phabricator.services.mozilla.com/D51747 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/613cdbb8111686c8be0b9a6e90b2bd92899226f0

Bug 1594500 - Document the memory layout of brush vertex shaders. r=gw

Loading status checks…

81159b7

Differential Revision: https://phabricator.services.mozilla.com/D52138 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/b7d3f7bb8f7c4a43392673bfb26e1efcfe438b55

bors-servo merged commit 7971c99 into servo:master Nov 8, 2019
2 of 3 checks passed

2 of 3 checks passed

Community-TC (pull_request) TaskGroup: failure
Details

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

homu Test successful
Details

bors-servo mentioned this pull request Nov 8, 2019

Move external image handler API into webrender_api #3796

Closed

servo / webrender

Sync changes from mozilla-central #3794

Sync changes from mozilla-central #3794

moz-gfx commented Nov 6, 2019

moz-gfx commented Nov 6, 2019

bors-servo commented Nov 6, 2019

This comment has been minimized.

community-tc-integration bot commented on `52cfe18` Nov 6, 2019

bors-servo commented Nov 6, 2019

bors-servo commented Nov 7, 2019

moz-gfx commented Nov 7, 2019

bors-servo commented Nov 7, 2019

bors-servo commented Nov 7, 2019

bors-servo commented Nov 7, 2019

jdm commented Nov 7, 2019

bors-servo commented Nov 7, 2019

jrmuizel commented Nov 7, 2019

bors-servo commented Nov 7, 2019

moz-gfx commented Nov 8, 2019

bors-servo commented Nov 8, 2019

bors-servo commented Nov 8, 2019

bors-servo commented Nov 8, 2019

SimonSapin commented Nov 8, 2019

petemoore commented Nov 8, 2019

moz-gfx commented Nov 8, 2019

bors-servo commented Nov 8, 2019

bors-servo commented Nov 8, 2019

bors-servo commented Nov 8, 2019

petemoore commented Nov 8, 2019

moz-gfx commented Nov 8, 2019

bors-servo commented Nov 8, 2019

bors-servo commented Nov 8, 2019

bors-servo commented Nov 8, 2019

bors-servo commented Nov 8, 2019

servo / webrender

Join GitHub today

Sync changes from mozilla-central #3794

Sync changes from mozilla-central #3794

Conversation

moz-gfx commented Nov 6, 2019

moz-gfx commented Nov 6, 2019

bors-servo commented Nov 6, 2019

This comment has been minimized.

community-tc-integration bot commented on 52cfe18 Nov 6, 2019

bors-servo commented Nov 6, 2019

bors-servo commented Nov 7, 2019

moz-gfx commented Nov 7, 2019

bors-servo commented Nov 7, 2019

bors-servo commented Nov 7, 2019

bors-servo commented Nov 7, 2019

jdm commented Nov 7, 2019

bors-servo commented Nov 7, 2019

jrmuizel commented Nov 7, 2019

bors-servo commented Nov 7, 2019

moz-gfx commented Nov 8, 2019

bors-servo commented Nov 8, 2019

bors-servo commented Nov 8, 2019

bors-servo commented Nov 8, 2019

SimonSapin commented Nov 8, 2019

petemoore commented Nov 8, 2019

moz-gfx commented Nov 8, 2019

bors-servo commented Nov 8, 2019

bors-servo commented Nov 8, 2019

bors-servo commented Nov 8, 2019

petemoore commented Nov 8, 2019

moz-gfx commented Nov 8, 2019

bors-servo commented Nov 8, 2019

bors-servo commented Nov 8, 2019

bors-servo commented Nov 8, 2019

bors-servo commented Nov 8, 2019

community-tc-integration bot commented on `52cfe18` Nov 6, 2019