Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove external image handler API into webrender_api #3796
Closed
Conversation
|
|
| @@ -21,6 +21,73 @@ use webrender::api::units::*; | |||
| #[cfg(target_os = "windows")] | |||
| use compositor_windows as compositor; | |||
|
|
|||
| #[cfg(not(target_os = "windows"))] | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jdm
Nov 12, 2019
Author
Member
It was relevant in that cargo build from the root directory is broken on non-windows platforms. In any case, I have submitted https://phabricator.services.mozilla.com/D52686 which only includes 34d64d0.
|
|
|
Was this done in #3797? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedNov 7, 2019
This reduces some unnecessary dependencies on webrender (vs webrender_api) in Servo and makes it more efficient to bisect during webrender upgrades.