Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IPC API. #3805

Closed
wants to merge 2 commits into from
Closed

Remove IPC API. #3805

wants to merge 2 commits into from

Conversation

@jdm
Copy link
Member

jdm commented Nov 28, 2019

This removes the use of ipc-channel. I would love to remove the Serialize/Deserialize lies as well, but last time I tried to do that proved harder than I anticipated.
@jdm
Force MPSC channels for API.
Loading status checks…
9c9bf0e
@kvark
Copy link
Member

kvark commented Nov 28, 2019

Why is this done?
@jrmuizel
Copy link
Contributor

jrmuizel commented Nov 28, 2019 

./Cargo.lock:1: duplicates for `crossbeam-utils` are allowed, but only single version found
	The following packages depend on version 0.2.2 from 'crates.io':
		crossbeam-deque
		crossbeam-epoch
@jrmuizel
Copy link
Contributor

jrmuizel commented Nov 28, 2019

the ipc-channel usage isn't need anymore because of servo/servo@564c16d
@jdm
Remove unused duplicate exemption.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
18467ce
@jdm
Copy link
Member Author

jdm commented Nov 28, 2019

Fixed the tidy issue.
@kvark
Copy link
Member

kvark commented Nov 28, 2019

error: Package webrender_api v0.60.0 (/home/worker/webrender/webrender_api) does not have these features: ipc
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2019

☔ The latest upstream changes (presumably #3809) made this pull request unmergeable. Please resolve the merge conflicts.
@atouchet
Copy link
Contributor

atouchet commented Apr 26, 2020

This was done in #3850.
@atouchet atouchet closed this Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @kvark @jrmuizel @bors-servo @atouchet
You can’t perform that action at this time.