Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central #3806
Merged
Conversation
This chanes the shader parsing code to only inject #included shader sources once (the first time) if they are included multiple times. This will allow some extra flexibility needed by the multi-brush shader. Differential Revision: https://phabricator.services.mozilla.com/D53651 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/a1138b7e56a3be562fe49e5b1dc755ed34ebf389
…. r=gw This will allow the upcoming super-brush shader to select its behavior at runtime. Differential Revision: https://phabricator.services.mozilla.com/D53724 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/9e1443b6c17c81bc5b074b4d33600a3717c55d8e
This is an experiment with only image and solid to see what the infrastructure can be like. If it works out I'll extend the it with more brush types. More work will be needed to get text rendering in there as well. The multi-brush shader includes all brushes that it potentially needs suport for. Which brushes actually get compiled in is then specified via WR_FEATURE defines. Since brushes can't have the same names for their entry points, they specify the function to use via a macros (WR_BRUSH_VS_FUNCTION and WR_BRUSH_FS_FUNCTION). Differential Revision: https://phabricator.services.mozilla.com/D53725 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/e55fa1d9bb896507057a99a33bf281598d2b287d
…ings. r=gw The 'multi-brush' shader will have to dynamically switch between different brushes. In order to support that without needing the sum of all brush varying locations, allow aliasing a number of generic slots. This patch makes the assumption that one a vec2 and a vec4 cost the same amount of varying register space, which is suggested by the glsl specification about shader locations. If it is not the case we can add more granularity to the varying slots which are all vec4 at the moment. This also assumes that an unused varying is always optimized out. Differential Revision: https://phabricator.services.mozilla.com/D53726 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/e5dad5475df4dfcec89e9ab4c137154fc91bddc3
Differential Revision: https://phabricator.services.mozilla.com/D53728 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/d4103eb1e6c5a951caa462814814933546c9c3d1
Differential Revision: https://phabricator.services.mozilla.com/D53993 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/dc267111d1744e222a971558d04b36ed22accd14
…r=gw Differential Revision: https://phabricator.services.mozilla.com/D53994 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/7a8c9a2678763b6bbfa7652a986deb0f40feae59
…ture. r=gw Differential Revision: https://phabricator.services.mozilla.com/D53995 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/2a87fc64de2fa5c7ae70deac4147699461394025
…ture. r=gw Differential Revision: https://phabricator.services.mozilla.com/D53996 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/ee4855adae883d56e7530b1e9f495bef1f7c69d0
Differential Revision: https://phabricator.services.mozilla.com/D53998 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/c54980f119ab56478452d2c4ecdb424d43238ae2
…. r=gw In GLES the default precision for ints is only 16 bits in the fragment shader. Differential Revision: https://phabricator.services.mozilla.com/D54000 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/576d4b85b28bdfe0f4f8b3f62c148bb517e6dd3f
See https://github.com/servo/webrender/wiki/Driver-issues#bug-1594128---glsl-on-macos-is-confused-by-a-function-that-just-returns-a-constant Differential Revision: https://phabricator.services.mozilla.com/D54691 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/1bcbb2e808a7ff611a33bc336bc3f2a8a514f2f8
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 28, 2019
Sync changes from mozilla-central
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedNov 28, 2019
No description provided.