Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central #3831
Merged
+243
−54
Conversation
…ical Opacity is a common effect that is used and the opacit filter path is also used when a stacking context has an opacity of < 1. The brush_blend shader is slow since it has support for a large portion of CSS filters; however, opacity is used much more often than the rest of the filters. This patch adds a simple shader for opacity effects which bypasses the extra overhead in the brush_blend shader. Differential Revision: https://phabricator.services.mozilla.com/D59610 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/b0226237c55e4a08f4deb622fc15fa1e85f39afc
I removed the old opacity filter path in the brush_blend shader and cleaned up the filter mode constants in the shader so there are less magic numbers. This should help if/when we move more filters to their own shaders. Depends on D59610 Differential Revision: https://phabricator.services.mozilla.com/D59611 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/5cd63d35010f9bf9538a37fb330127d459b7ccc0
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 14, 2020
Sync changes from mozilla-central
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedJan 14, 2020
No description provided.