Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #3833

Merged
merged 32 commits into from Jan 15, 2020
Merged

Conversation

@moz-gfx
Copy link

moz-gfx commented Jan 15, 2020

No description provided.

SimonSapin and others added 30 commits Jan 15, 2020
Adds an #ifdef to the DCLayerTree implementation that allows
selecting whether to use the virtual surface API (enabled by
default) or the regular DC surface API.

For now, this is a compile-time switch. As a follow up to this,
we will support both options at runtime (for example, using the
regular surface API for surfaces that have holes or translucency).

Differential Revision: https://phabricator.services.mozilla.com/D58870

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/1d212c2ddb76f5d54fd884e8e08001fc8475e13c
This adds support for holes within virtual surfaces. On platforms
that don't use virtual surfaces, this just works by destroying
the tile that is empty so it never gets composited.

Differential Revision: https://phabricator.services.mozilla.com/D59059

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/e9d191b5eb8a78b117f55c0dd6993cb0d136c7c8
Easy to miss that the slow formatting code is run unconditionally.
The remaining instances are in recording and startup code.

Differential Revision: https://phabricator.services.mozilla.com/D58920

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/031a2ee21fa6e2b2983b1619ebdf65caa2b882a6
…ack clippy lints. r=Gankro

I don't think it makes much of a difference but clippy is quite vocal about it.

Differential Revision: https://phabricator.services.mozilla.com/D59114

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/d70cc2bb33f62aab04ee8a5ae5a086bcee5ab974
Backed out changeset a3942fa2644c (bug 1607697)
Backed out changeset 6bf3305bb689 (bug 1607697)
Backed out changeset 3af5a9700d47 (bug 1607697)
Backed out changeset 6101f5e31e46 (bug 1607697)
Backed out changeset d70cc2bb33f6 (bug 1607697)
Backed out changeset 8490fa04e0ee (bug 1607697)
Backed out changeset 6c1778a36720 (bug 1607697)
Backed out changeset 9e830c9157ae (bug 1607697)

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/c2dd65b196d31e375f8dd4b1ac91e955847ac3c7
…ack clippy lints. r=Gankro

I don't think it makes much of a difference but clippy is quite vocal about it.

Differential Revision: https://phabricator.services.mozilla.com/D59114

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/966cc16c3feb7ec46352e9ecff3fd65a3723ab8f
…ical

Opacity is a common effect that is used and the opacit filter path is also used when a stacking
context has an opacity of < 1. The brush_blend shader is slow since it has support for a large
portion of CSS filters; however, opacity is used much more often than the rest of the filters.
This patch adds a simple shader for opacity effects which bypasses the extra overhead in the
brush_blend shader.

Differential Revision: https://phabricator.services.mozilla.com/D59610

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/b0226237c55e4a08f4deb622fc15fa1e85f39afc
I removed the old opacity filter path in the brush_blend shader and cleaned up the filter mode
constants in the shader so there are less magic numbers. This should help if/when we move more
filters to their own shaders.

Depends on D59610

Differential Revision: https://phabricator.services.mozilla.com/D59611

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/5cd63d35010f9bf9538a37fb330127d459b7ccc0
@moz-gfx
Copy link
Author

moz-gfx commented Jan 15, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Jan 15, 2020

📌 Commit 93c7a2b has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented Jan 15, 2020

Testing commit 93c7a2b with merge 79ad94d...

bors-servo added a commit that referenced this pull request Jan 15, 2020
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented Jan 15, 2020

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: auto
Pushing 79ad94d to master...

@bors-servo bors-servo merged commit 93c7a2b into servo:master Jan 15, 2020
3 checks passed
3 checks passed
Community-TC (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@kvark
Copy link
Member

kvark commented Jan 15, 2020

Hooray! The first PR made by github-sync that evolved from wrupdater. cc @staktrace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
You can’t perform that action at this time.