Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3839
Merged
+23
−22
Conversation
… in some cases. r=Bert The semantics of the inaccuracy reftest mode are that the overall test succeeds as long as one of the multiple test images mismatches the reference image. However, the previous implementation would print an unexpected result if any of the comparisons were equal (even though the overall test result would be reported correctly). This patch changes wrench so that it only reports an unexpected failure for the overall test, not each individual reference. Differential Revision: https://phabricator.services.mozilla.com/D60564 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/3d076ae68a9411e4f412c90d2743987f7b916850
…taro,nical There are a number of issues with the current gradient dithering implementation, that cause many test failures and also fuzziness rendering when enabling DirectComposition virtual surfaces. In particular, the dither result is dependent on the offset of the update rect within a render target. For now, this patch disables gradient dithering by default. This gives us: - A heap of new test PASS results (or reduced fuzziness). - Fixes a number of non-deterministic fuzziness bugs with DC. - Improves performance of gradient rendering by a reasonable amount. We can fix gradient dithering as a follow up, and re-enable if/when we find content that would benefit from it significantly (we may be able to improve gradients in other ways than dithering too). Differential Revision: https://phabricator.services.mozilla.com/D60460 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/f758f235dd70f1060dba771ccfd3cb91a9aaef20
|
@bors-servo r=auto |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 22, 2020
Sync changes from mozilla-central gfx/wr
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedJan 22, 2020
No description provided.