Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3841
Merged
+165
−51
Conversation
and others
added 7 commits
Jan 23, 2020
…enshot r=gw Differential Revision: https://phabricator.services.mozilla.com/D59658 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/f3b490c076d623d6ef3bcfd297a0522d9727477c
…regarding CompositorKindChanged CLOSED TREE [ghsync] From https://hg.mozilla.org/mozilla-central/rev/52234324a69eb012bac0b0897a66b754f416e413
Differential Revision: https://phabricator.services.mozilla.com/D59356 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/8b8a272428800614fcbc975c1ed93b663950ba89
…muizel,kvark border-image-repeat: Round is equivalent to Repeat with the pattern size adjusted to fill the area with a whole number of repetitions. This is done by adjusting the segment's stretch_size in the shader so that it fits a whole number of times in the segment's size. Differential Revision: https://phabricator.services.mozilla.com/D59370 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/6b61867f80b123f11aa3e9252f0ac005a12787c0
Unlike the border areas that only nead their own dimensions, the middle area of a border-image determines its repetition parameter based on the size of the borders. A new flag is provided for the brush_image shader to know whether to use the segment's own rect or look at the borders when computing the pattern's size. Differential Revision: https://phabricator.services.mozilla.com/D59675 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/834d49acd3c02a7e5ae75d0a4d01a55e69c8fdba
The computation of the repetition depends on the aspect ratio of the segment's uv rectangle, which was previously represented by the dx/dy variables in the shader. These were mistakenly computing the ratio of the normalized uvs within the primitive's total uv rect, which was incorrect since the normalization introduces a non-uniform scale. This patch fixes it by taking the uv size in device pixels instead of the the normalized textel rect. dx and dy are also renamed into segment_uv_size which is a more informative name. Differential Revision: https://phabricator.services.mozilla.com/D60768 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/b77165c764503ccf3b0f52b60fff265d4048ba6e
Differential Revision: https://phabricator.services.mozilla.com/D59901 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/5ad1eff4ce669f10abba3e70b0be0e9cb378f651
|
@bors-servo r=auto |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 23, 2020
Sync changes from mozilla-central gfx/wr
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedJan 23, 2020
No description provided.