Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #3849

Merged
merged 2 commits into from Feb 4, 2020
Merged

Conversation

@moz-gfx
Copy link

moz-gfx commented Feb 4, 2020

No description provided.

…ical

There's two potential cases handled by this patch:

(1) A scrollbar container followed by another scrollbar container.
    In this case, we need to ensure these are placed into separate
    clusters, even though the cluster flags otherwise match, to
    ensure that slice creation will see the two clusters.

(2) If a fixed position scroll root trails a scrollbar container.
    In this case, ensure that a scrollbar contains marks the
    cluster flags to create a slice straight after the scrollbar,
    to avoid other primitives with the same scroll root sneaking
    into the scrollbar container.

Differential Revision: https://phabricator.services.mozilla.com/D61519

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/e1a4153cfb39a6e1706e88f036d6874bd0ddc39c
@moz-gfx
Copy link
Author

moz-gfx commented Feb 4, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2020

📌 Commit 57903b1 has been approved by auto

bors-servo added a commit that referenced this pull request Feb 4, 2020
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2020

Testing commit 57903b1 with merge 5840c7b...

@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2020

💔 Test failed - status-appveyor

@moz-gfx
Copy link
Author

moz-gfx commented Feb 4, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2020

📌 Commit b4e31d4 has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2020

Testing commit b4e31d4 with merge 6878b54...

bors-servo added a commit that referenced this pull request Feb 4, 2020
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2020

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: auto
Pushing 6878b54 to master...

@bors-servo bors-servo merged commit b4e31d4 into servo:master Feb 4, 2020
3 checks passed
3 checks passed
Community-TC (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.