Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #3856

Merged
merged 9 commits into from Feb 12, 2020
Merged

Conversation

@moz-gfx
Copy link

moz-gfx commented Feb 11, 2020

No description provided.

@moz-gfx
Copy link
Author

moz-gfx commented Feb 11, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2020

📌 Commit e1432a7 has been approved by auto

bors-servo added a commit that referenced this pull request Feb 11, 2020
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2020

Testing commit e1432a7 with merge 83b9bc0...

@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2020

💔 Test failed - status-appveyor

gw3583 and others added 7 commits Feb 12, 2020
…tor implementations. r=sotaro,mstange

For Draw (non-native) and CA modes, we include the per-tile
valid rect in the clip rect from the surface.

For DC (non-virtual) mode, a per-tile clip rect is set on the
visual for each tile, separate from the overall clip rect that
is set on the surface visual.

For DC (virtual) mode, the Trim API is used to remove pixels
in the virtual tile area that are outside the valid / clipped
region.

Note: Although the valid rect is now applied in the native
compositors, it's currently only based on the overall picture
cache bounding rect. Thus, with this patch there isn't any
noticeable performance improvement. Once this lands and is
working correctly, the follow up patch to calculate a smaller
valid region per-tile is a small amount of work.

Differential Revision: https://phabricator.services.mozilla.com/D61424

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/174d5be06caa95bdc01153cdd8cff5152f406b6f
With this patch, a minimal valid rect is calculated for each
picture cache tile. This is used to reduce the scissor rect
during tile rasterization, and the draw rect during tile
compositing, whenever there is a partial tile.

Differential Revision: https://phabricator.services.mozilla.com/D62177

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/b174d2f9072d36738d5dc484526d51a3a4f2ef82
…d r=gw

composite_simple() calculates combined dirty rect from all tile's dirty rect. But the combined dirty rect becomes invalid when there is an old tile that was dropped. The dropped tile's dirty rect is not counted in composite_simple().

Differential Revision: https://phabricator.services.mozilla.com/D62531

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/8e08016b3d0acf0c5c3116b087d5455df573d99c
@moz-gfx
Copy link
Author

moz-gfx commented Feb 12, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Feb 12, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 12, 2020

📌 Commit a5108f4 has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented Feb 12, 2020

Testing commit a5108f4 with merge 5f1ec78...

bors-servo added a commit that referenced this pull request Feb 12, 2020
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented Feb 12, 2020

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: auto
Pushing 5f1ec78 to master...

@bors-servo bors-servo merged commit a5108f4 into servo:master Feb 12, 2020
3 checks passed
3 checks passed
Community-TC (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.