Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #3872

Merged
merged 33 commits into from Mar 6, 2020
Merged

Conversation

@moz-gfx
Copy link

moz-gfx commented Feb 27, 2020

No description provided.

hiikezoe and others added 10 commits Feb 27, 2020
Backed out changeset 28a2fba71977 (bug 1510030)
Backed out changeset 1700b3a416cd (bug 1510030)
Backed out changeset 087518046b0c (bug 1510030)
Backed out changeset 6b3af91a7ce6 (bug 1510030)
Backed out changeset 737f4bc3afd3 (bug 1510030)
Backed out changeset 921116ca67a5 (bug 1510030)

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/7fc17499b72099c0fa5d27f76c619229c01f2516
…html failures CLOSED TREE

Backed out changeset a14a131ca731 (bug 1510030)
Backed out changeset a75359516fec (bug 1510030)
Backed out changeset a2be11cbe3f2 (bug 1510030)
Backed out changeset b37ce2b87ac7 (bug 1510030)
Backed out changeset 781cd96dd9a2 (bug 1510030)
Backed out changeset b3dfa17c6305 (bug 1510030)

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/7d06c5f0f339c0016c764d49ebe6962b177a1e15
@moz-gfx
Copy link
Author

moz-gfx commented Feb 27, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

📌 Commit 1fc3512 has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

Testing commit 1fc3512 with merge 0d5435a...

bors-servo added a commit that referenced this pull request Feb 27, 2020
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

💔 Test failed - status-appveyor

@moz-gfx
Copy link
Author

moz-gfx commented Feb 27, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

📌 Commit 7b1f4fa has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

Testing commit 7b1f4fa with merge 9aa9cbb...

bors-servo added a commit that referenced this pull request Feb 27, 2020
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

💔 Test failed - status-appveyor

jfkthame and others added 3 commits Feb 29, 2020
…AX_BLUR after scale factors are applied r=gfx-reviewers,nical

This was causing one of the large drop-shadow wrench reftests to timeout.
This is only a partial fix, as we should be checking the scale factors earlier on when sanitizing the
filter input. This will ensure we match what the non-WR backend is doing and will prevent overinflation.

Differential Revision: https://phabricator.services.mozilla.com/D64197

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/b7ab4c947688fab1ee8de2ef13a6033e2307d590
@moz-gfx
Copy link
Author

moz-gfx commented Feb 29, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
staktrace and others added 2 commits Mar 4, 2020
Rather than treating webrender::intern::UpdateList as a sequence of operations,
each of which might be an insertion or a removal, and using a side table to
supply extra data for insertions, it's simpler to segregate insertions and
removals into two separate vectors. This avoids the need for an enum whose
discriminant needs to be checked within the loop, and allows a few loops that
are only looking for one kind of operation to skip over the others entirely.

Ultimately, there should be no change in the order in which operations occur. In
practice, the old UpdateList always held a contiguous run of insertions,
followed by a run of removals (removals are consumed by apply_updates directly
after being generated by end_frame_and_get_pending_updates).

Differential Revision: https://phabricator.services.mozilla.com/D64444

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/06e238addde26dee65ee29f3cb676d7d47ff4e6e
@moz-gfx
Copy link
Author

moz-gfx commented Mar 4, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2020

📌 Commit 517a4b6 has been approved by auto

Ensure that the image keys and image generations for external
compositor surfaces are included in the composite descriptor,
which is used to determine if a composite is required or can
be skipped.

Differential Revision: https://phabricator.services.mozilla.com/D65216

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/5f2a8eb4989755c3cf987738ea04034ac5bea896
@moz-gfx
Copy link
Author

moz-gfx commented Mar 4, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2020

📌 Commit bf01196 has been approved by auto

@staktrace
Copy link
Contributor

staktrace commented Mar 4, 2020

@bors-servo retry

@staktrace
Copy link
Contributor

staktrace commented Mar 4, 2020

@jdm does bors need a kick?

Add support for a `fuzzy-range` keyword in reftest.list.
It is similar to `fuzzy` but it allows multiple pairs of
`max_difference, num_differences` numbers that introduce
multiple buckets of allowed differences.

For example, `fuzzy-range(5,100,20,10)` allows at most
100 pixels with a difference of at most 5, _plus_ an extra
10 pixels at most that have a difference more than 5 but
less than or equal to 20.
The total number of differing pixels allowed is thus 110,
but only if 100 of those differ by <= 5 and the remaining
10 by <= 20.
110 pixels with a difference <= 5 will still fail.
This is intentional to encourage tighter bounds in tests
where many pixels are slightly off and a few outliers are
off by a lot.

The number of parameters is arbitrary; longer lists can
get confusing so this change also introduces optional
support for writing `<=` in front of the max difference
and `*` in front of the max pixel count, eg.
`fuzzy-range(<=5,*100,<=20,*10)` (no spaces).

Any pixels that exceed the highest maximum will fail the
test, similar to `fuzzy`.

Steps tested:
1. the same tests fail in exactly the same way before and after;
2. reordered the `fuzzy` statements for raster_root_A/B/C to no longer
   be sorted by max difference, and verified that the tests pass/fail
   the same way;
   (then sort them again which is easier to understand);
3. tests using the new feature still fail when the ref no longer matches
   (deliberately broke the _ref version and verified test failed);

Differential Revision: https://phabricator.services.mozilla.com/D65247

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/8c07488c9a3f0a76e01ce34e060d071a2310612d
@moz-gfx
Copy link
Author

moz-gfx commented Mar 5, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Mar 5, 2020

📌 Commit a1991bc has been approved by auto

@moz-gfx
Copy link
Author

moz-gfx commented Mar 5, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Mar 5, 2020

📌 Commit 8d121d8 has been approved by auto

bors-servo added a commit that referenced this pull request Mar 5, 2020
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented Mar 5, 2020

Testing commit 8d121d8 with merge 1fef9fc...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 5, 2020

💔 Test failed - status-appveyor

@staktrace
Copy link
Contributor

staktrace commented Mar 5, 2020

Another fuzz difference in AppVeyor, put patch on https://phabricator.services.mozilla.com/D65513

staktrace and others added 4 commits Mar 6, 2020
…. r=Bert,sotaro

This patch refactors how external surfaces are stored in the
CompositeState structure. This is primarily to simplify integration
with native compositor mode, but also simplifies the Draw compositor
path.

Previously, the ResolvedExternalSurface struct contained information
that was used to rasterize the external surface (YUV planes etc) and
also the information to composite it (device rect, clip rect, z_id).

Now, ResolvedExternalSurface contains just the information required
to rasterize the external surface, while the compositing information
is handled by adding the external surface as a regular tile. This
makes it possible to unify how external surfaces are drawn, via the
common draw_tile_list method.

Differential Revision: https://phabricator.services.mozilla.com/D65269

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/4bbb79cbf9cc9efc7d599d1fe8d68bf620601fc9
…taro

This patch adds support for external compositor surfaces when
using native compositor mode.

Differential Revision: https://phabricator.services.mozilla.com/D65436

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/c3a689bf10e1dd2b1dc04fe0494584561bd8421b
…ender_task.rs:37 r=gw

Adding a repro-case reftest that asks for a 19996x5000 RenderTask (at
-p1), then fix it in analogy with the clamping to reasonable values that
happens for `NormalBorder`.

Differential Revision: https://phabricator.services.mozilla.com/D65660

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/14caf2826f00fc609f7fe55d8df14e7e08fd1ced
@moz-gfx
Copy link
Author

moz-gfx commented Mar 6, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

📌 Commit 51b4045 has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

Testing commit 51b4045 with merge bef0584...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: auto
Pushing bef0584 to master...

@bors-servo bors-servo merged commit bef0584 into servo:master Mar 6, 2020
3 checks passed
3 checks passed
Community-TC (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.