Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove sha256 from dependencies (closes #3586) #3875
Closed
Conversation
|
Tests passed. r? @kvark |
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Mar 11, 2020
[import_pr] From servo/webrender#3875 Differential Revision: https://phabricator.services.mozilla.com/D66064
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 12, 2020
[import_pr] From servo/webrender#3875 Differential Revision: https://phabricator.services.mozilla.com/D66064 --HG-- extra : moz-landing-system : lando
moz-gfx
added a commit
to moz-gfx/webrender
that referenced
this pull request
Mar 12, 2020
[import_pr] From servo#3875 Differential Revision: https://phabricator.services.mozilla.com/D66064 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/ab8746bb808719748e77de3d8ba538574bceee8c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 12, 2020
[import_pr] From servo/webrender#3875 Differential Revision: https://phabricator.services.mozilla.com/D66064 UltraBlame original commit: ab8746bb808719748e77de3d8ba538574bceee8c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 12, 2020
[import_pr] From servo/webrender#3875 Differential Revision: https://phabricator.services.mozilla.com/D66064 UltraBlame original commit: ab8746bb808719748e77de3d8ba538574bceee8c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 12, 2020
[import_pr] From servo/webrender#3875 Differential Revision: https://phabricator.services.mozilla.com/D66064 UltraBlame original commit: ab8746bb808719748e77de3d8ba538574bceee8c
|
This landed upstream in https://phabricator.services.mozilla.com/D66064, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fschutt commentedMar 7, 2020
•
edited
#3586 -
Sha256::new()can be safely replaced byDefaultHasher::new()since its only used for verifying shaders if they use an different source file.Note that there seems to have been a change in Rust Edition 2018 so that
Hasher::inputwas renamed toHasher::write. Not sure if this impacts the supported compiler versions.