Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upStore the last rendered epoch for all pipelines. #388
Merged
Conversation
|
r? @pcwalton |
|
Could you add a link to the Servo issue number in the comment? |
|
|
Instead of storing the last rendered epoch for each pipeline from the previous frame, accumulate this information for each frame. This is a workaround for the way servo's compositor keeps iframes in the frame tree when they are invisible. This is a workaround for servo/servo#13149. Long term, we should find a better solution for this.
|
@pcwalton Rebased and added comment. |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 6, 2016
Store the last rendered epoch for all pipelines. Instead of storing the last rendered epoch for each pipeline from the previous frame, accumulate this information for each frame. This is a workaround for the way servo's compositor keeps iframes in the frame tree when they are invisible. Long term, we should find a better solution for this. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/388) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedSep 5, 2016
•
edited by larsbergstrom
Instead of storing the last rendered epoch for each pipeline from
the previous frame, accumulate this information for each frame.
This is a workaround for the way servo's compositor keeps iframes
in the frame tree when they are invisible.
Long term, we should find a better solution for this.
This change is