Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3880
Merged
Conversation
build_frame is called by update_document which calls rebuild_hit_tester if the hit test tree is invalidated. The advantage of doing it there is that it is after the frame has been submitted to the renderer so we are out of the critical path and the work can overlap with draw call submission. So we don't need to do the work in build_frame, and since we don't currently set the validity flag there we are often re-building the hit test tree a second time after frame building. Differential Revision: https://phabricator.services.mozilla.com/D64328 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/a2ddfcc2a7d4815dfe479d9138a91eb70fab5a10
…es complaining about hittest tests CLOSED TREE [ghsync] From https://hg.mozilla.org/mozilla-central/rev/6b61e86e08037ba077a5f149fcaad73c6fc1ea42
|
@bors-servo r=auto |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 10, 2020
Sync changes from mozilla-central gfx/wr
|
|
build_frame is called by update_document which calls rebuild_hit_tester if the hit test tree is invalidated. The advantage of doing it there is that it is after the frame has been submitted to the renderer so we are out of the critical path and the work can overlap with draw call submission. So we don't need to do the work in build_frame, and since we don't currently set the validity flag there we are often re-building the hit test tree a second time after frame building. Differential Revision: https://phabricator.services.mozilla.com/D64328 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/2c6a51317166bb8b3c90781b3bc7739448c72a0b
|
@bors-servo r=auto |
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedMar 10, 2020
No description provided.