Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #3880

Merged
merged 3 commits into from Mar 11, 2020
Merged

Commits on Mar 10, 2020

  1. Bug 1618132 - Avoid redundant hit test tree builds. r=gw

    build_frame is called by update_document which calls rebuild_hit_tester if the hit test tree is invalidated. The advantage of doing it there is that it is after the frame has been submitted to the renderer so we are out of the critical path and the work can overlap with draw call submission.
    
    So we don't need to do the work in build_frame, and since we don't currently set the validity flag there we are often re-building the hit test tree a second time after frame building.
    
    Differential Revision: https://phabricator.services.mozilla.com/D64328
    
    [ghsync] From https://hg.mozilla.org/mozilla-central/rev/a2ddfcc2a7d4815dfe479d9138a91eb70fab5a10
    nical authored and moz-gfx committed Mar 10, 2020
  2. Backed out changeset a2ddfcc2a7d4 (bug 1618132) for mochitests failur…

    …es complaining about hittest tests CLOSED TREE
    
    [ghsync] From https://hg.mozilla.org/mozilla-central/rev/6b61e86e08037ba077a5f149fcaad73c6fc1ea42
    bogdantara authored and moz-gfx committed Mar 10, 2020
  3. Bug 1618132 - Avoid redundant hit test tree builds. r=gw

    build_frame is called by update_document which calls rebuild_hit_tester if the hit test tree is invalidated. The advantage of doing it there is that it is after the frame has been submitted to the renderer so we are out of the critical path and the work can overlap with draw call submission.
    
    So we don't need to do the work in build_frame, and since we don't currently set the validity flag there we are often re-building the hit test tree a second time after frame building.
    
    Differential Revision: https://phabricator.services.mozilla.com/D64328
    
    [ghsync] From https://hg.mozilla.org/mozilla-central/rev/2c6a51317166bb8b3c90781b3bc7739448c72a0b
    nical authored and moz-gfx committed Mar 10, 2020
You can’t perform that action at this time.