Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #3883

Merged
merged 23 commits into from Mar 18, 2020
Merged

Sync changes from mozilla-central gfx/wr #3883

merged 23 commits into from Mar 18, 2020
+17,882 −378

Conversation

@moz-gfx
Copy link

moz-gfx commented Mar 13, 2020

No description provided.

sefeng211 and others added 2 commits Mar 13, 2020
@sefeng211 @moz-gfx
Bug 1600793 - Make the scrolling input telemetry work for WebRender r…
fd7d948 
…=botond,jrmuizel

Differential Revision: https://phabricator.services.mozilla.com/D60046

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/b781fe3bde1aed855813cc97f7250885a3512a0c
dev @moz-gfx
Bug 1621758 - Fix occlusion rect of clipped compositor surfaces. r=ms…
Loading status checks…
a1d5938 
…tange

Differential Revision: https://phabricator.services.mozilla.com/D66506

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/4bd0143d7cbe6e8271e36f449de2673e70d4b9b4
@moz-gfx
Copy link
Author

moz-gfx commented Mar 13, 2020

@bors-servo r=auto
@bors-servo
Copy link
Contributor

bors-servo commented Mar 13, 2020

📌 Commit a1d5938 has been approved by auto
bors-servo added a commit that referenced this pull request Mar 13, 2020
@bors-servo
Auto merge of #3883 - moz-gfx:github-sync, r=auto
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e30d5b5 
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented Mar 13, 2020

⌛ Testing commit a1d5938 with merge e30d5b5...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 13, 2020

💔 Test failed - status-taskcluster
@staktrace
Copy link
Contributor

staktrace commented Mar 13, 2020 •
edited 

error: use of deprecated item 'std::error::Error::description': use the Display impl or to_string()
  --> webrender_api/src/channel.rs:83:71
   |
83 |         self.rx.recv().map_err(|e| io::Error::new(ErrorKind::Other, e.description()))
   |                                                                       ^^^^^^^^^^^
   |
   = note: `-D deprecated` implied by `-D warnings`

Compiler bump caused this. Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1622256
jrmuizel and others added 2 commits Mar 13, 2020
@jrmuizel @moz-gfx
Bug 1622327. Add support for adding profiling event markers to WebRen…
0fe639d 
…der. r=kvark

I plan on using this to add texture cache reallocation events.

Differential Revision: https://phabricator.services.mozilla.com/D66792

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/2f04abdb752c6d2cc25882d2ee4783aed2a8e8eb
@ccoroiu @moz-gfx
Backed out changeset 2f04abdb752c (bug 1622327) for build bustage on …
Loading status checks…
f17d613 
…a CLOSED TREE

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/23925b6dcab718c6ad0dcec41e1f48c2a30cabcd
@moz-gfx
Copy link
Author

moz-gfx commented Mar 13, 2020

@bors-servo r=auto
@bors-servo
Copy link
Contributor

bors-servo commented Mar 13, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 13, 2020

📌 Commit f17d613 has been approved by auto
bors-servo added a commit that referenced this pull request Mar 13, 2020
@bors-servo
Auto merge of #3883 - moz-gfx:github-sync, r=auto
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a48b92b 
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented Mar 13, 2020

⌛ Testing commit f17d613 with merge a48b92b...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 13, 2020

💔 Test failed - status-taskcluster
Lee Salzman added 10 commits Mar 14, 2020
Lee Salzman @moz-gfx
Bug 1612941 - add deinit hook to WR Compositor trait. r=gw
9f2341a 
Differential Revision: https://phabricator.services.mozilla.com/D65591

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/bdf468af2e58f9dc651f8d062a3da90be8a412a5
Lee Salzman @moz-gfx
Bug 1612941 - add SWGL glue to wrench. r=jrmuizel
d919041 
Differential Revision: https://phabricator.services.mozilla.com/D65593

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/3c5eddbc74b6c68fd45edac8dbc8fcf0433b08c7
Lee Salzman @moz-gfx
Bug 1612941 - make WR report shader name and features in output for i…
9396fb2 
…nterop with SWGL. r=jrmuizel

Differential Revision: https://phabricator.services.mozilla.com/D65595

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/558806ca76911093f504fb80232840f395f39d06
Lee Salzman @moz-gfx
Bug 1612941 - properly detect GL_ARB_texture_swizzle extension in WR.…
84bab7f 
… r=gw,kvark

Differential Revision: https://phabricator.services.mozilla.com/D65596

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/5097c1d4e3d7751134b60a8ecb775382a5f6ae44
Lee Salzman @moz-gfx
Bug 1612941 - only upload partial GPU cache rows in WR when possible …
e83684e 
…to minimize memory churn. r=gw

Differential Revision: https://phabricator.services.mozilla.com/D65598

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/a85061249e46c13dda65e808526a1a62a3a60dfb
Lee Salzman @moz-gfx
Bug 1612941 - support variable depth buffer size in WR. r=gw
fde0ad2 
Differential Revision: https://phabricator.services.mozilla.com/D65602

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/b6ea5a6b0a721defdc7e9aa2a7af54897ad1a0e2
Lee Salzman @moz-gfx
Bug 1612941 - force immediate upload method for SWGL since PBOs are s…
bac5c57 
…lower there. r=jrmuizel

Differential Revision: https://phabricator.services.mozilla.com/D65613

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/39adb08e0acafdf063aff479c29b9b9462555ac8
Lee Salzman @moz-gfx
Bug 1612941 - WR shader changes to support SWGL instance attribs. r=j…
d7d3927 
…rmuizel,gw

Add annotations to vertex shaders so that SWGL can detect when a vertex attribute
is generated by per-instance data rather than per-vertex data.

Differential Revision: https://phabricator.services.mozilla.com/D65614

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/cf730c4e65393b07f842ab6f58c2509a1009f920
Lee Salzman @moz-gfx
Bug 1612941 - update gleam version to allow implementation of Gl trai…
830a0e3 
…t. r=jrmuizel

Differential Revision: https://phabricator.services.mozilla.com/D65615

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/46024d1d85b3026c38f7336887a03ceae6875182
Lee Salzman @moz-gfx
Bug 1612941 - vendor SWGL's rust dependencies. r=froydnj
Loading status checks…
964e6c5 
Differential Revision: https://phabricator.services.mozilla.com/D65617

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/08e87bebb6062948732562a9f3e641563dd87390
@moz-gfx
Copy link
Author

moz-gfx commented Mar 14, 2020

@bors-servo r=auto
@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2020

📌 Commit f17d613 has been approved by auto
Lee Salzman @moz-gfx
Bug 1622520 - only run Renderbuffer cleanup code when erased. r=jrmuizel
Loading status checks…
b32e67c 
Differential Revision: https://phabricator.services.mozilla.com/D66868

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/6b4b41968cc165237c76b231d3ce5fcd46dc59ff
Lee Salzman and others added 2 commits Mar 17, 2020
Lee Salzman @moz-gfx
Bug 1622591 - add missing YUV shader variations. r=jrmuizel
537f681 
Differential Revision: https://phabricator.services.mozilla.com/D66885

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/d5280d6879b80da4113e978e5dc7df089969bcb6
@gw3583 @moz-gfx
Bug 1622720 - Add support for the tracy frame profiler to webrender. …
Loading status checks…
bbc57cf 
…r=nical,jrmuizel

This patch removes the old thread_profiler bindings, and adds
support for profiling WR with the tracy profiler, which is a
much more advanced frame profiler.

Since it's very lightweight, and only instruments annotated CPU
and GPU zones, it can retain very large profiles, allowing
fine grained analysis of thread interactions, CPU spikes etc.

Differential Revision: https://phabricator.services.mozilla.com/D66926

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/f8203119cca43d25f2879ebea2b904e4355e59ad
@moz-gfx
Copy link
Author

moz-gfx commented Mar 17, 2020

@bors-servo r=auto
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

📌 Commit 7482bd3 has been approved by auto
@staktrace
Copy link
Contributor

staktrace commented Mar 17, 2020

@bors-servo r-
@staktrace
Copy link
Contributor

staktrace commented Mar 17, 2020

@bors-servo r=auto
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

📌 Commit bbc57cf has been approved by auto
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

⌛ Testing commit bbc57cf with merge 8b15666...
bors-servo added a commit that referenced this pull request Mar 17, 2020
@bors-servo
Auto merge of #3883 - moz-gfx:github-sync, r=auto
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8b15666 
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

💔 Test failed - status-appveyor
@staktrace
Copy link
Contributor

staktrace commented Mar 17, 2020

Build execution time has reached the maximum allowed time for your plan (100 minutes).
@nical @moz-gfx
Bug 1618116 - Remove synchronous hit testing from WebRender's C++ wra…
Loading status checks…
dcac3cc 
…pper. r=botond,kats

In addition:
 - Move the fast hit tester to the rust side of the bindings.
 - Avoid blocking by requesting a hit tester early and only blocking if the request isn't delivered by the time of the first hit test query.

Differential Revision: https://phabricator.services.mozilla.com/D66994

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/6096a87c64ab2717f1b0c670589dad69ee219269
@moz-gfx
Copy link
Author

moz-gfx commented Mar 17, 2020

@bors-servo r=auto
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

📌 Commit bbc57cf has been approved by auto
@staktrace
Copy link
Contributor

staktrace commented Mar 17, 2020

@bors-servo r-
@staktrace
Copy link
Contributor

staktrace commented Mar 17, 2020

@bors-servo r=auto
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

📌 Commit dcac3cc has been approved by auto
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

⌛ Testing commit dcac3cc with merge 8596fee...
bors-servo added a commit that referenced this pull request Mar 17, 2020
@bors-servo
Auto merge of #3883 - moz-gfx:github-sync, r=auto
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8596fee 
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

💔 Test failed - status-appveyor
@nical @moz-gfx
Bug 1615613 - Integrate the text shader in the brush infrastructure. …
Loading status checks…
2f3e55b 
…r=gw

As a strating point for the vertex shader, this patch isolates the parts that are common to both shaders: the code that fetches various piece of data, adding a branching point between the text shader and other brushes just after having fetched most of the data. Hopefully we can devise ways to further unify the vertex shaders in followups.

Differential Revision: https://phabricator.services.mozilla.com/D63094

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/26255dd68307e91c80f322ff18233ed22739127d
@moz-gfx
Copy link
Author

moz-gfx commented Mar 17, 2020

@bors-servo r=auto
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

📌 Commit 2f3e55b has been approved by auto
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

⌛ Testing commit 2f3e55b with merge 9fe2470...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 18, 2020

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: auto
Pushing 9fe2470 to master...
@bors-servo bors-servo merged commit 9fe2470 into servo:master Mar 18, 2020
3 checks passed
3 checks passed
Community-TC (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@staktrace staktrace mentioned this pull request Mar 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@moz-gfx @bors-servo @staktrace @sefeng211 @jrmuizel @ccoroiu @gw3583 @nical
You can’t perform that action at this time.