Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace AtomicU64 with AtomicUsize #3884
Closed
+3
−3
Conversation
|
CI doesn't like it? |
|
It appears unrelated.
|
|
If you rebase your PR on the latest master that error should go away. (It was fixed in bug 1622256 which got merged in #3883) |
PowerPC and MIPS do not have AtomicU64, but AtomicUsize is a more portable type that can be used as a replacement.
|
Thanks, that CI build seems to succeed now. |
|
Created https://bugzilla.mozilla.org/show_bug.cgi?id=1623407, will port the PR shortly. |
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Mar 18, 2020
PowerPC and MIPS do not have AtomicU64, but AtomicUsize is a more portable type that can be used as a replacement. [import_pr] From servo/webrender#3884 Differential Revision: https://phabricator.services.mozilla.com/D67365
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 19, 2020
PowerPC and MIPS do not have AtomicU64, but AtomicUsize is a more portable type that can be used as a replacement. [import_pr] From servo/webrender#3884 Differential Revision: https://phabricator.services.mozilla.com/D67365 --HG-- extra : moz-landing-system : lando
moz-gfx
added a commit
to moz-gfx/webrender
that referenced
this pull request
Mar 19, 2020
PowerPC and MIPS do not have AtomicU64, but AtomicUsize is a more portable type that can be used as a replacement. [import_pr] From servo#3884 Differential Revision: https://phabricator.services.mozilla.com/D67365 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/ff701e82864569f328f9466ba5fdbfb0273354d6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 19, 2020
PowerPC and MIPS do not have AtomicU64, but AtomicUsize is a more portable type that can be used as a replacement. [import_pr] From servo/webrender#3884 Differential Revision: https://phabricator.services.mozilla.com/D67365 UltraBlame original commit: ff701e82864569f328f9466ba5fdbfb0273354d6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 19, 2020
PowerPC and MIPS do not have AtomicU64, but AtomicUsize is a more portable type that can be used as a replacement. [import_pr] From servo/webrender#3884 Differential Revision: https://phabricator.services.mozilla.com/D67365 UltraBlame original commit: ff701e82864569f328f9466ba5fdbfb0273354d6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 19, 2020
PowerPC and MIPS do not have AtomicU64, but AtomicUsize is a more portable type that can be used as a replacement. [import_pr] From servo/webrender#3884 Differential Revision: https://phabricator.services.mozilla.com/D67365 UltraBlame original commit: ff701e82864569f328f9466ba5fdbfb0273354d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dm0- commentedMar 17, 2020
PowerPC and MIPS do not have
AtomicU64, butAtomicUsizeis a more portable type that can be used as a replacement: https://doc.rust-lang.org/std/sync/atomic/index.html#portabilityI hit this build failure while trying to cross-compile Firefox for PowerPC. It could use
AtomicU32and.into()instead, but the size type will keep a 64-bit value where supported.