Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3888
Merged
+209
−103
Conversation
…at a time. r=gw As an initial step to reduce the reallocation churn a bit. This texture array grows up to 12 layers for any trivial page and goes up to 40+ on many sites (like the youtube front page) so it's far from enough but it's a start. Simple popups like Help > About Nightly don't need more than 4 layers, though. Differential Revision: https://phabricator.services.mozilla.com/D67366 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/a781ce6dd0204621001b60c291601dd7f5666690
Also make sure that the pressure factor never gets to zero. These new constants aren't deinitive in any way though I think that they are a bit more reasonable. Depends on D67366 Differential Revision: https://phabricator.services.mozilla.com/D67367 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/86167a71e7060d373e5ca4148e0e47ae5169d616
…uct. r=gw Doesn't make for a stellar API but texture_cache.rs has a lot of code and I had a hard time wrapping my head around the scattered parts of picture-cache specific code. In addition (and more importantly) texture arrays for each tile sizes can be allocated on demand and do not need to be created when initializing the texture cache. This avoids allocating and deallocating the mispredicted picture texture size when the initial window size is garbage. Depends on D67367 Differential Revision: https://phabricator.services.mozilla.com/D67368 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/955e7790f963c0c99ab8ab6ba537491a24023939
…platforms. r=gw It was previously set on mac only due to driver mischiefs, however the cost of growing texture arrays becomes high with large layer counts, which capping the layer count to 32 everywhere helps mitigate at the expense of batch breaks. Depends on D67368 Differential Revision: https://phabricator.services.mozilla.com/D67369 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/8f4b47079a44eeea87caa560b3b072148551aa3c
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedMar 19, 2020
No description provided.