Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3904
Merged
Conversation
Differential Revision: https://phabricator.services.mozilla.com/D69227 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/27e38d793959eb04381346a00a46cd59bc009933
Before this patch: - Consume time merely is the time it takes to push something into a vector (always displays zero). - Total IPC time and the DisplayList IPC graph measure the time between api.set_display_list and the render backend picking the message up, plus the time it took to build the display list (but doesn't take into account the time it took for actual IPC in between). - Send time is only the time between api.set_display_list and the render backend picking the message up but doesn't take into account the time it took between the content thread sending the DL and the compositor thread forwarding it. After this patch: - Content send time measures the time between the content thread sending the display list and the compositor forwarding it (actual IPC). - Api send time measures the time between the compostor thread forwarding the DL and the render backend picking it up. - Consume time is removed. - Total send time is the sum of content and api times. - Display list build times and display list IPC (total send time) are on separate graphs. Depends on D69227 Differential Revision: https://phabricator.services.mozilla.com/D69228 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/ea22f0b1e2a0d0a237048452f930529bc773ffbd
Differential Revision: https://phabricator.services.mozilla.com/D68985 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/7ce59e5c51d63f3f88a882092e59a9f1bf3453a5
This removes the WebRender side of the previous slow frame indicator and replace it with a simple implementation that only looks at the CPU time on the render backend and renderer thread involved for building a frame. A followup patch will add a separate indicator for when the displaylist/ipc/scene bits take too long. Differential Revision: https://phabricator.services.mozilla.com/D69247 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/3ca010d7a52d68e7fbc2e91edaeb980cdd6e76fb
It moves when DL building + IPC + scene building takes more than 100ms. Depends on D69247 Differential Revision: https://phabricator.services.mozilla.com/D69254 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/af4366c6c434242d656db2c4b6779dd50a35b94a
… the scene builder thread. r=jrmuizel Instead of collecting so-called ipc counters when receving the SetDisplayList on the render backend, pass the information through the scene builder thread and update the profile on the render backend after the scene is swapped. This prevents ipc counters to be displayed while the transaction is still being processed by the scene builder thread. Differential Revision: https://phabricator.services.mozilla.com/D69414 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/1a729c8ea63134fb2746cad5639cde022ea4919b
…rs. r=jrmuizel Few of the counters actually have anything to do with IPC although they all relate to events of layout transactions. Depends on D69414 Differential Revision: https://phabricator.services.mozilla.com/D69415 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/d2771cdff401747f61d5302cdf7a284eb851b1ce
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedApr 3, 2020
No description provided.