Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3907
Merged
Conversation
Depends on D69634 Differential Revision: https://phabricator.services.mozilla.com/D69648 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/c98499d204fb8df645daf3e2841d0b3955141e90
this is an attempt to handle tasks outside of the device bounds, that belong to surfaces not establishing raster roots. I suspect that the scaling we are now setting up in adjust_scale_for_max_surface_size doesn't work properly, since the function was assumed to only affect the raster-rooted surfaces. But it does fix the crash we have. Differential Revision: https://phabricator.services.mozilla.com/D69654 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/745c38db6468c26d2ee4c0cdfc5f9ec0b6733db9
The picture cache code retains a set of tiles that are currently off-screen but might be needed again soon, depending on how the page is scrolled. However, off-screen tiles were being skipped during draw processing, which meant that the texture cache request method was not being called on these tiles. This would often result in the texture cache eagerly evicting these seemingly unused surface tiles. This patch re-arranges the occlusion and visibility processing code for tiles, so that if a tile has been retained in the picture cache grid, the texture surface is always requested, even if that tile is currently off-screen. This prevents the texture cache from evicting tiles that we want to retain for now. Differential Revision: https://phabricator.services.mozilla.com/D69760 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/c39512f89aedf7c0745137da9c8c09a54f9ab2e8
Differential Revision: https://phabricator.services.mozilla.com/D68945 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/376011a4881e966bf359cda3d10658191525af13
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedApr 7, 2020
No description provided.