Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3908
Merged
Conversation
and others
added 4 commits
Apr 7, 2020
… texture function. r=cbrewster The `sampleInUvRect` function in `gfx/wr/webrender/res/cs_svg_filter.glsl` calls `texture`, passing the optional third argument that specifies a bias to the sampler's level-of-detail calculation, used for mipmap interpolation. However, the `texture` override in `gfx/wr/swgl/src/glsl.h` that accepts this parameter is stubbed out, with an `assert(0)`. This causes twelve tests in `gfx/wr/wrench/reftests/filters` to crash. Nothing in Firefox uses mipmaps, and Servo doesn't use Software WebRender, so it should be fine for that call to `texture` to simply not pass the level-of-detail bias. This patch makes that change. Differential Revision: https://phabricator.services.mozilla.com/D69867 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/89e164da5af7b9a9152deacdb06bb5b36d3bf2b8
Differential Revision: https://phabricator.services.mozilla.com/D69894 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/31efa8051c3a4b54c07bfa361784d274c8dc847f
Differential Revision: https://phabricator.services.mozilla.com/D69873 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/80476f6d2daa4f842ef10e916c495540132fe25b
…aders with PERSPECTIVE feature. r=jrmuizel This implements Z plane clipping, gl_FragCoord.zw interpolation, and vertex attribute perspective-correction with support from the glsl-to-cxx compiler by using PERSPECTIVE feature in a WR shader. Differential Revision: https://phabricator.services.mozilla.com/D69429 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/88a4ebce9de0a0b261747ce7327f26600a551475
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedApr 7, 2020
No description provided.