Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3910
Merged
Conversation
… node tree changes. r=nical,Bert,kvark Previously, primitive dependency checking would invalidate a tile if the spatial node index for a given primitive changed. However, if a new display list is sent that changes the shape of the spatial node tree this may cause unnecessary invalidations. For example, a new display list that inserts a new spatial node at the start of the tree could result in spatial node indices being different, even though the values of the transforms was the same. This patch changes the invalidation logic for spatial nodes to compare the transforms by value, rather than index, meaning that invalidations are avoided if the shape of the spatial tree has changed, but the values are consistent. Differential Revision: https://phabricator.services.mozilla.com/D69913 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/498d2204d63739057b626da3239d130c412099e0
This fixes a case where the backing surface of a picture cache tile changes, but was still being considered a no-op frame, which skips the composite as an optimization if nothing has changed. In this case, the tile surface changes from a rasterized texture to a solid color that doesn't require a picture cache texture. The patch ensures that the composite surface descriptors that are used to detect no-op frame compositions include the backing surface for each of the tiles that make up this virtual surface. Differential Revision: https://phabricator.services.mozilla.com/D70138 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/5b784c47235ccd535d694c1ec2caf5b341570ff1
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedApr 8, 2020
No description provided.