Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #3915

Merged
merged 1 commit into from Apr 13, 2020
Merged

Conversation

@moz-gfx
Copy link

moz-gfx commented Apr 13, 2020

No description provided.

…rect. r=sotaro

Previously, it was possible for a tile that had a valid scroll root
to have an empty valid (and dirty) rect due to the picture cache
clip rect, in some situations.

This could result in the tile not being tagged as off-screen, which
means it is added to the queue of tiles to be updated. On most
platforms this is benign, but the BeginDraw method of DirectComposition
fails if the dirty rect is empty.

This patch fixes the logic so that tiles that meet these conditions
are correctly tagged as not visible, and skipped from update queue.

Differential Revision: https://phabricator.services.mozilla.com/D70616

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/73632227ba00df584e8f6fcc1191e6dfa13fc5fd
@moz-gfx
Copy link
Author

moz-gfx commented Apr 13, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Apr 13, 2020

📌 Commit 8b0d34e has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented Apr 13, 2020

Testing commit 8b0d34e with merge dd524f0...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 13, 2020

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: auto
Pushing dd524f0 to master...

@bors-servo bors-servo merged commit dd524f0 into servo:master Apr 13, 2020
3 checks passed
3 checks passed
Community-TC (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.